Skip site navigation (1)Skip section navigation (2) 
Date:      Sun, 13 Dec 2015 04:29:09 +0000 (UTC)
From:      Garrett Cooper <ngie@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   svn commit: r292152 - stable/10/lib/libc/tests/stdio
Message-ID:  <201512130429.tBD4T9nI087292@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: ngie
Date: Sun Dec 13 04:29:09 2015
New Revision: 292152
URL: https://svnweb.freebsd.org/changeset/base/292152

Log:
  MFC r291980,r291981:
  
  r291980:
  
  Add missing va_ends for corresponding va_starts to clean up variable arguments
  initialized in _test_fmt(..)
  
  Reported by: cppcheck
  Sponsored by: EMC / Isilon Storage Division
  
  r291981:
  
  Delete bogus freeing of uninitialized data
  
  Reported by: cppcheck
  Sponsored by: EMC / Isilon Storage Division

Modified:
  stable/10/lib/libc/tests/stdio/getdelim_test.c
  stable/10/lib/libc/tests/stdio/printbasic_test.c
  stable/10/lib/libc/tests/stdio/printfloat_test.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/lib/libc/tests/stdio/getdelim_test.c
==============================================================================
--- stable/10/lib/libc/tests/stdio/getdelim_test.c	Sun Dec 13 04:24:59 2015	(r292151)
+++ stable/10/lib/libc/tests/stdio/getdelim_test.c	Sun Dec 13 04:29:09 2015	(r292152)
@@ -208,7 +208,6 @@ ATF_TC_BODY(empty_NULL_buffer, tc)
 
 	/* Make sure NULL *linep and zero *linecapp are handled. */
 	fp = mkfilebuf();
-	free(line);
 	line = NULL;
 	linecap = 42;
 	ATF_REQUIRE(getline(&line, &linecap, fp) == sizeof(apothegm) - 1);

Modified: stable/10/lib/libc/tests/stdio/printbasic_test.c
==============================================================================
--- stable/10/lib/libc/tests/stdio/printbasic_test.c	Sun Dec 13 04:24:59 2015	(r292151)
+++ stable/10/lib/libc/tests/stdio/printbasic_test.c	Sun Dec 13 04:29:09 2015	(r292152)
@@ -94,6 +94,8 @@ _testfmt(const char *result, const char 
 		    "wprintf(\"%ls\", %s) ==> [%ls], expected [%ls]\n",
 		    wfmt, argstr, ws, wresult);
 	}
+	va_end(ap);
+	va_end(ap2);
 }
 
 ATF_TC_WITHOUT_HEAD(int_within_limits);

Modified: stable/10/lib/libc/tests/stdio/printfloat_test.c
==============================================================================
--- stable/10/lib/libc/tests/stdio/printfloat_test.c	Sun Dec 13 04:24:59 2015	(r292151)
+++ stable/10/lib/libc/tests/stdio/printfloat_test.c	Sun Dec 13 04:29:09 2015	(r292152)
@@ -86,6 +86,8 @@ _testfmt(const char *result, const char 
 		    "wprintf(\"%ls\", %s) ==> [%ls], expected [%ls]\n",
 		    wfmt, argstr, ws, wresult);
 	}
+	va_end(ap);
+	va_end(ap2);
 }
 
 ATF_TC_WITHOUT_HEAD(float_within_limits);

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201512130429.tBD4T9nI087292>