Date: Mon, 4 Sep 2023 12:10:56 -0600 From: Warner Losh <imp@bsdimp.com> To: Michael Gmelin <grembo@freebsd.org> Cc: Matthias Apitz <guru@unixarea.de>, Alexander Motin <mav@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: 14.0-CURRENT boots fine but keyboard does not work Message-ID: <CANCZdfre5vW%2BQinsUXuwrROS_70iR%2Bpyz9Y7BWcWXxYuZEakxQ@mail.gmail.com> In-Reply-To: <58E9D0C9-747F-4DEB-9DC7-5A2E8C54EABF@freebsd.org> References: <ZPYVKL74wlue%2BOuu@c720-r368166> <58E9D0C9-747F-4DEB-9DC7-5A2E8C54EABF@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Mon, Sep 4, 2023, 11:40 AM Michael Gmelin <grembo@freebsd.org> wrote: > > > On 4. Sep 2023, at 19:34, Matthias Apitz <guru@unixarea.de> wrote: > > El día lunes, septiembre 04, 2023 a las 07:29:41p. m. +0200, Michael > Gmelin escribió: > > > > On 4. Sep 2023, at 19:23, Matthias Apitz <guru@unixarea.de> wrote: > > > > > Added Alexander Motin <mav@FreeBSD.org> to To: as the origin of the CI; > > > Neither hw.atkbd.hz=1 nor hw.atkbd.hz=10 makes the keyboard working on > > my beloved Acer C720. Should I file a new PR? > > > > Filing a PR makes sense, could you please Cc me on it? > > > Do you know which version of FreeBSD was the last that worked for you? > > > I'm actually using (and typing this on it) r368166. Will file a PR > tomorrow. Thanks > > > This could also be related: > > > https://cgit.freebsd.org/src/commit/?id=319d2bf407b3762da6f1c67ffe8dce2fee587aaf > > You could try to undo that patch and build a new kernel. > It shouldn't make a difference... but I may have been given bad advice if it did... if it's this one, I'll help sort it out. Warner Best > Michael > > > > matthias > > El día lunes, septiembre 04, 2023 a las 06:55:52p. m. +0200, Michael > Gmelin escribió: > > > > > On Mon, 4 Sep 2023 18:43:11 +0200 > > Matthias Apitz <guru@unixarea.de> wrote: > > > I have a 14.0-CURRENT compiled from sources of head from August 4, > > which boots fine from a produced USB key, but the keyboard does not > > work on an Acer C720 (amd64), on other laptops the keyboard is fine. > > > The keyboard works during the boot menu (for example to enable verbose > > boot messages) but not on the login: prompt of the booted system. > > > I've enabled SSH access into the C720 (if someone need more > > information) and I'm attaching /var/log/messages of the booted system. > > > Hi Matthias, > > > The C720 required special patches for the keyboard to work, which I > > originally added here: > > > https://cgit.freebsd.org/src/commit/?id=6c176113bbdd598231ec47d161d4c3714997169b > > > I assume that something in that area changed recently. > > > Without digging into it, this looks like a possible cause: > > > > https://cgit.freebsd.org/src/commit/sys/dev/atkbdc/atkbd.c?id=ce881170088c4c98c036fe561f8ee8413c2e2585 > > > atkbd: Disable periodic polling by default. > > It is one of the few remaining Giant-locked callouts. It would be > > good to remove it, not mentioning that polling itself is not good. > > > If this cause keyboard/mouse freezes on some hardware, please set > > loader tunable hw.atkbd.hz=1 as workaround and report the issue. > > > So you could try to set hw.atkbd.hz=1 (or hw.atkbd.hz=10) in > > /boot/loader.conf, then reboot and see if it helps. > > > Best > > Michael > > > -- > > Michael Gmelin > > > > -- > > Matthias Apitz, ✉ guru@unixarea.de, http://www.unixarea.de/ > +49-176-38902045 > > Public GnuPG key: http://www.unixarea.de/key.pub > > > > > -- > Matthias Apitz, ✉ guru@unixarea.de, http://www.unixarea.de/ > +49-176-38902045 > Public GnuPG key: http://www.unixarea.de/key.pub > > [-- Attachment #2 --] <div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Sep 4, 2023, 11:40 AM Michael Gmelin <<a href="mailto:grembo@freebsd.org">grembo@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><div dir="ltr"></div><div dir="ltr"><br></div><div dir="ltr"><br><blockquote type="cite">On 4. Sep 2023, at 19:34, Matthias Apitz <<a href="mailto:guru@unixarea.de" target="_blank" rel="noreferrer">guru@unixarea.de</a>> wrote:<br><br></blockquote></div><blockquote type="cite"><div dir="ltr"><span>El día lunes, septiembre 04, 2023 a las 07:29:41p. m. +0200, Michael Gmelin escribió:</span><br><span></span><br><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><blockquote type="cite"><span>On 4. Sep 2023, at 19:23, Matthias Apitz <<a href="mailto:guru@unixarea.de" target="_blank" rel="noreferrer">guru@unixarea.de</a>> wrote:</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>Added Alexander Motin <mav@FreeBSD.org> to To: as the origin of the CI;</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>Neither hw.atkbd.hz=1 nor hw.atkbd.hz=10 makes the keyboard working on</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>my beloved Acer C720. Should I file a new PR?</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>Filing a PR makes sense, could you please Cc me on it?</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>Do you know which version of FreeBSD was the last that worked for you?</span><br></blockquote><span></span><br><span>I'm actually using (and typing this on it) r368166. Will file a PR</span><br><span>tomorrow. Thanks</span><br><span></span><br></div></blockquote><div><br></div><div>This could also be related:</div><div><br></div><div><a href="https://cgit.freebsd.org/src/commit/?id=319d2bf407b3762da6f1c67ffe8dce2fee587aaf" target="_blank" rel="noreferrer">https://cgit.freebsd.org/src/commit/?id=319d2bf407b3762da6f1c67ffe8dce2fee587aaf</a></div><div><br></div><div>You could try to undo that patch and build a new kernel.</div></div></blockquote></div></div><div dir="auto"><br></div><div dir="auto">It shouldn't make a difference... but I may have been given bad advice if it did... if it's this one, I'll help sort it out.</div><div dir="auto"><br></div><div dir="auto">Warner</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><div>Best</div><div>Michael</div><div><br></div><div><br></div><br><blockquote type="cite"><div dir="ltr"><span> matthias</span><br><span></span><br><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>El día lunes, septiembre 04, 2023 a las 06:55:52p. m. +0200, Michael Gmelin escribió:</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>On Mon, 4 Sep 2023 18:43:11 +0200</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>Matthias Apitz <<a href="mailto:guru@unixarea.de" target="_blank" rel="noreferrer">guru@unixarea.de</a>> wrote:</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>I have a 14.0-CURRENT compiled from sources of head from August 4,</span><br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>which boots fine from a produced USB key, but the keyboard does not</span><br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>work on an Acer C720 (amd64), on other laptops the keyboard is fine.</span><br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>The keyboard works during the boot menu (for example to enable verbose</span><br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>boot messages) but not on the login: prompt of the booted system.</span><br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>I've enabled SSH access into the C720 (if someone need more</span><br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>information) and I'm attaching /var/log/messages of the booted system.</span><br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>Hi Matthias,</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>The C720 required special patches for the keyboard to work, which I</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>originally added here:</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span><a href="https://cgit.freebsd.org/src/commit/?id=6c176113bbdd598231ec47d161d4c3714997169b" target="_blank" rel="noreferrer">https://cgit.freebsd.org/src/commit/?id=6c176113bbdd598231ec47d161d4c3714997169b</a></span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>I assume that something in that area changed recently.</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>Without digging into it, this looks like a possible cause:</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span> <a href="https://cgit.freebsd.org/src/commit/sys/dev/atkbdc/atkbd.c?id=ce881170088c4c98c036fe561f8ee8413c2e2585" target="_blank" rel="noreferrer">https://cgit.freebsd.org/src/commit/sys/dev/atkbdc/atkbd.c?id=ce881170088c4c98c036fe561f8ee8413c2e2585</a></span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span> atkbd: Disable periodic polling by default.</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span> It is one of the few remaining Giant-locked callouts. It would be</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span> good to remove it, not mentioning that polling itself is not good.</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span> If this cause keyboard/mouse freezes on some hardware, please set</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span> loader tunable hw.atkbd.hz=1 as workaround and report the issue.</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>So you could try to set hw.atkbd.hz=1 (or hw.atkbd.hz=10) in</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>/boot/loader.conf, then reboot and see if it helps.</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>Best</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>Michael</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>-- </span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span>Michael Gmelin</span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>-- </span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>Matthias Apitz, ✉ <a href="mailto:guru@unixarea.de" target="_blank" rel="noreferrer">guru@unixarea.de</a>, <a href="http://www.unixarea.de/" target="_blank" rel="noreferrer">http://www.unixarea.de/</a>; +49-176-38902045</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>Public GnuPG key: <a href="http://www.unixarea.de/key.pub" target="_blank" rel="noreferrer">http://www.unixarea.de/key.pub</a></span><br></blockquote></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><span></span><br><span>-- </span><br><span>Matthias Apitz, ✉ <a href="mailto:guru@unixarea.de" target="_blank" rel="noreferrer">guru@unixarea.de</a>, <a href="http://www.unixarea.de/" target="_blank" rel="noreferrer">http://www.unixarea.de/</a>; +49-176-38902045</span><br><span>Public GnuPG key: <a href="http://www.unixarea.de/key.pub" target="_blank" rel="noreferrer">http://www.unixarea.de/key.pub</a></span><br></div></blockquote></div></blockquote></div></div></div>;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfre5vW%2BQinsUXuwrROS_70iR%2Bpyz9Y7BWcWXxYuZEakxQ>