Date: Mon, 3 Jul 2023 22:36:53 -0600 From: Warner Losh <imp@bsdimp.com> To: Pedro Giffuni <pfg@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: 4456846a1a0d - main - bin/date: Upgrade calculations Message-ID: <CANCZdfo%2BAZYU0EzRtZv-mNQhGogUddD%2BgJijkJyrGS-SQ19jqA@mail.gmail.com> In-Reply-To: <1767168745.2134945.1688443634249@mail.yahoo.com> References: <202307040308.36438MTA093771@gitrepo.freebsd.org> <CANCZdfqMvf1QuS=fNQjRPe3YUbp1zPQW4aorh=VTRHk%2Bf_e8qg@mail.gmail.com> <1037448433.54513.1688441647903@mail.yahoo.com> <CANCZdfrSnS5Xq020jwsY-pgmTCJEn5Ka3Zr5vqt6OK%2Buawc4tA@mail.gmail.com> <1767168745.2134945.1688443634249@mail.yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Mon, Jul 3, 2023, 10:07 PM Pedro Giffuni <pfg@freebsd.org> wrote:
> (Sorry for top posting)
>
> Oh yes, the analysis is fine, and it is quicker to fix than what I had in
> mind.
>
> I'll take a look at fixing it now, but due to external issues I may have
> to leave the fix for next weekend.
>
Ah great. I'll not have time to fix this... thanks for taking care of
this... sorry if i was a It grumpy... it's been a day...
Warner
Pedro.
>
>
> On Monday, July 3, 2023 at 11:00:51 PM GMT-5, Warner Losh <imp@bsdimp.com>
> wrote:
>
>
>
>
> On Mon, Jul 3, 2023, 9:34 PM Pedro Giffuni <pfg@freebsd.org> wrote:
>
> Hmm ...
>
> Dragonfly has no armv7 or i386, so they didn't get it too wrong.
> I guess the int64_t would be a quick fix or another option, which I was
> consideirng, was to look at unsigning it but taking care of the edge cases
> ... I was too lazy for that.
>
> Please go ahead and do the quick fix ;)
>
>
> What makes you say it's a quick fix? If the calculations need 64 bits,
> int64_t is the proper data type. How is that analysis wrong?
>
> Also, it's tradition that you should fix it...
>
> Warner
>
[-- Attachment #2 --]
<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jul 3, 2023, 10:07 PM Pedro Giffuni <<a href="mailto:pfg@freebsd.org">pfg@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div style="font-family:Helvetica Neue,Helvetica,Arial,sans-serif;font-size:16px"><div></div>
<div dir="ltr">(Sorry for top posting)</div><div><br></div><div dir="ltr">Oh yes, the analysis is fine, and it is quicker to fix than what I had in mind.</div><div dir="ltr"><br></div><div dir="ltr">I'll take a look at fixing it now, but due to external issues I may have to leave the fix for next weekend.</div></div></div></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Ah great. I'll not have time to fix this... thanks for taking care of this... sorry if i was a It grumpy... it's been a day...</div><div dir="auto"><br></div><div dir="auto">Warner</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div style="font-family:Helvetica Neue,Helvetica,Arial,sans-serif;font-size:16px"><div dir="ltr">Pedro.</div><div><br></div><div><br></div>
</div><div id="m_-2495992665827709045ydp39addca9yahoo_quoted_9236065441">
<div style="font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:13px;color:#26282a">
<div>
On Monday, July 3, 2023 at 11:00:51 PM GMT-5, Warner Losh <<a href="mailto:imp@bsdimp.com" target="_blank" rel="noreferrer">imp@bsdimp.com</a>> wrote:
</div>
<div><br></div>
<div><br></div>
<div><div id="m_-2495992665827709045ydp39addca9yiv4277734352"><div><div><div><br clear="none"><br clear="none"><div><div dir="ltr">On Mon, Jul 3, 2023, 9:34 PM Pedro Giffuni <<a shape="rect" href="mailto:pfg@freebsd.org" rel="nofollow noreferrer" target="_blank">pfg@freebsd.org</a>> wrote:<br clear="none"></div><blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div style="font-family:Helvetica Neue,Helvetica,Arial,sans-serif;font-size:16px"><div></div>
<div dir="ltr">Hmm ...</div><div dir="ltr"><br clear="none"></div><div dir="ltr">Dragonfly has no armv7 or i386, so they didn't get it too wrong.</div><div dir="ltr">I guess <span><span style="color:rgb(0,0,0);font-family:Helvetica Neue,Helvetica,Arial,sans-serif;font-size:16px">the int64_t would be a quick fix or</span></span> another option, which I was consideirng, was to look at unsigning it but taking care of the edge cases ... I was too lazy for that.</div><div><br clear="none"></div><div dir="ltr">Please go ahead and do the quick fix ;)</div></div></div></blockquote></div></div><div><br clear="none"></div><div>What makes you say it's a quick fix? If the calculations need 64 bits, int64_t is the proper data type. How is that analysis wrong?</div><div><br clear="none"></div><div>Also, it's tradition that you should fix it...</div><div><br clear="none"></div><div>Warner</div></div><div id="m_-2495992665827709045ydp39addca9yiv4277734352yqtfd43229">
</div></div></div></div>
</div>
</div></div></blockquote></div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfo%2BAZYU0EzRtZv-mNQhGogUddD%2BgJijkJyrGS-SQ19jqA>