Date: Thu, 30 Oct 2014 13:26:02 +0300 From: Andrey Chernov <ache@freebsd.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: ports <ports@freebsd.org>, ruby@FreeBSD.org Subject: Re: Can't build ruby20 on -current: it doesn't honor WITHOUT_CDDL=yes Message-ID: <5452123A.40108@freebsd.org> In-Reply-To: <20141030101739.GD63624@ivaldir.etoilebsd.net> References: <54520ED5.6040907@freebsd.org> <20141030101739.GD63624@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 30.10.2014 13:17, Baptiste Daroussin wrote: > On Thu, Oct 30, 2014 at 01:11:33PM +0300, Andrey Chernov wrote: >> Hi. >> I disable zfs and dtrace on my machine using WITHOUT_CDDL=yes in >> /etc/src.conf >> ryby20 port throw this error: >> ... >> checking for valgrind/memcheck.h... no >> checking for strip... strip >> configure: error: dtrace(1) is missing >> ===> Script "configure" failed unexpectedly. >> >> I see you have sophisticated check depending on OS version for >> CONFIGURE_ARGS+= --enable-dtrace >> IMHO, it should be replaced to test dtrace binary presence instead. >> > > To be previse the port should not care about WITHOUT_CDDL :) but it should > detect if the host has dtrace or note, probably a > .if exists(/usr/sbin/dtrace) > CONFIGURE_ARGS+= --enable-dtrace > .endif > > Should do the trick (to be tested of course :) Yes, the thing .if exists(/usr/sbin/dtrace) CONFIGURE_ARGS+= --enable-dtrace .else CONFIGURE_ARGS+= --disable-dtrace .endif works (at least for no dtrace case) -- http://ache.vniz.net/ [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJUUhJBAAoJEKUckv0MjfbKUX8IAL5vcW2X/xmqNCrgpGUKALmw g9EsRMo2ft+dQrmH7nREinmNUAiNG0uQWG64OD1E7nRiil0Oyo412VXXpuLm4458 cS0ggeD549DtzE3L+dEmqi9B4f2eIeCea97ODrdcaE/YEr6fRTKcCxnbugleZoqB U4erQXIlvY6xMjvrtbUrmNeDJbm6CdeJsTdjsPsxKk4vlVY9gcY5uMqatKj3QWo7 s7iE6NqTh8ZrmW6cyJJ+se2V/Gy4SNFtMtXh38U6kCKOx7ZnZAuOMk5VGvipkXKq OAV0rpyrzouEnq0nz4E04+fWbB2fmMHkPSBGW/CJ/UXmt7wLPF1w77wYDPVgoGY= =FAiH -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5452123A.40108>