Date: Mon, 25 Mar 2024 07:37:54 -0700 From: Mark Peek <mp@freebsd.org> To: garyj@gmx.de Cc: Mark Peek <mp@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 65904399db91 - main - efibootmgr: allow -u as a valid option Message-ID: <CAGGgMJenrGwEHNmN4jkPqsT6NwCQauQBm0JpLReFOsPK7Q31nw@mail.gmail.com> In-Reply-To: <20240325100136.2a052359@ernst.home> References: <202403241939.42OJdn3w018764@gitrepo.freebsd.org> <20240325100136.2a052359@ernst.home>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Mon, Mar 25, 2024 at 2:01 AM Gary Jennejohn <garyj@gmx.de> wrote: > On Sun, 24 Mar 2024 19:39:49 GMT > Mark Peek <mp@FreeBSD.org> wrote: > > > The branch main has been updated by mp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=65904399db9167b0970e42e14642e1d6bdbf6d3a > > > > commit 65904399db9167b0970e42e14642e1d6bdbf6d3a > > Author: Mark Peek <mp@FreeBSD.org> > > AuthorDate: 2024-03-24 19:37:12 +0000 > > Commit: Mark Peek <mp@FreeBSD.org> > > CommitDate: 2024-03-24 19:37:12 +0000 > > > > efibootmgr: allow -u as a valid option > > > > PR: 277907 > > Reported by: vsasjason@gmail.com > > MFC after: 1 week > > --- > > usr.sbin/efibootmgr/efibootmgr.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/usr.sbin/efibootmgr/efibootmgr.c > b/usr.sbin/efibootmgr/efibootmgr.c > > index 2bc79ee26f51..b919130d9c11 100644 > > --- a/usr.sbin/efibootmgr/efibootmgr.c > > +++ b/usr.sbin/efibootmgr/efibootmgr.c > > @@ -204,8 +204,8 @@ parse_args(int argc, char *argv[]) > > int ch; > > const char *arg; > > > > - while ((ch = getopt_long(argc, argv, > "AaBb:C:cdDe:EFfhk:L:l:NnOo:pTt:v", > > - lopts, NULL)) != -1) { > > + while ((ch = getopt_long(argc, argv, > > + "AaBb:C:cdDe:EFfhk:L:l:NnOo:pTt:u:v", lopts, NULL)) != -1) { > > switch (ch) { > > case 'A': > > opts.set_inactive = true; > > > > -u is not documented in the man page for efibootmgr, although it was > already in the source. > > -- > Gary Jennejohn > Gary, I'm not sure I understand your comment. The man page was updated for -u in this commit: https://github.com/freebsd/freebsd-src/commit/9a7915299484a767fbffc7234b8dc45c29954cca And man shows this as: efibootmgr -u unix-path ... -u --efidev unix-path Displays the UEFI device path of unix-path. Mark [-- Attachment #2 --] <div dir="ltr"><div dir="ltr">On Mon, Mar 25, 2024 at 2:01 AM Gary Jennejohn <<a href="mailto:garyj@gmx.de">garyj@gmx.de</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Sun, 24 Mar 2024 19:39:49 GMT<br> Mark Peek <mp@FreeBSD.org> wrote:<br> <br> > The branch main has been updated by mp:<br> ><br> > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=65904399db9167b0970e42e14642e1d6bdbf6d3a" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=65904399db9167b0970e42e14642e1d6bdbf6d3a</a><br>; ><br> > commit 65904399db9167b0970e42e14642e1d6bdbf6d3a<br> > Author: Mark Peek <mp@FreeBSD.org><br> > AuthorDate: 2024-03-24 19:37:12 +0000<br> > Commit: Mark Peek <mp@FreeBSD.org><br> > CommitDate: 2024-03-24 19:37:12 +0000<br> ><br> > efibootmgr: allow -u as a valid option<br> ><br> > PR: 277907<br> > Reported by: <a href="mailto:vsasjason@gmail.com" target="_blank">vsasjason@gmail.com</a><br> > MFC after: 1 week<br> > ---<br> > usr.sbin/efibootmgr/efibootmgr.c | 4 ++--<br> > 1 file changed, 2 insertions(+), 2 deletions(-)<br> ><br> > diff --git a/usr.sbin/efibootmgr/efibootmgr.c b/usr.sbin/efibootmgr/efibootmgr.c<br> > index 2bc79ee26f51..b919130d9c11 100644<br> > --- a/usr.sbin/efibootmgr/efibootmgr.c<br> > +++ b/usr.sbin/efibootmgr/efibootmgr.c<br> > @@ -204,8 +204,8 @@ parse_args(int argc, char *argv[])<br> > int ch;<br> > const char *arg;<br> ><br> > - while ((ch = getopt_long(argc, argv, "AaBb:C:cdDe:EFfhk:L:l:NnOo:pTt:v",<br> > - lopts, NULL)) != -1) {<br> > + while ((ch = getopt_long(argc, argv,<br> > + "AaBb:C:cdDe:EFfhk:L:l:NnOo:pTt:u:v", lopts, NULL)) != -1) {<br> > switch (ch) {<br> > case 'A':<br> > opts.set_inactive = true;<br> ><br> <br> -u is not documented in the man page for efibootmgr, although it was<br> already in the source.<br> <br> --<br> Gary Jennejohn<br></blockquote><div><br></div><div>Gary,</div><div>I'm not sure I understand your comment. The man page was updated for -u in this commit:</div><div><a href="https://github.com/freebsd/freebsd-src/commit/9a7915299484a767fbffc7234b8dc45c29954cca">https://github.com/freebsd/freebsd-src/commit/9a7915299484a767fbffc7234b8dc45c29954cca</a><br><br>And man shows this as:</div><div><font face="monospace"> efibootmgr -u unix-path</font></div><div><font face="monospace"> ...</font></div><div><font face="monospace"> -u --efidev unix-path<br> Displays the UEFI device path of unix-path.</font><br></div><div><br></div><div>Mark</div></div></div>help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGGgMJenrGwEHNmN4jkPqsT6NwCQauQBm0JpLReFOsPK7Q31nw>