Date: Mon, 25 Mar 2024 07:37:54 -0700 From: Mark Peek <mp@freebsd.org> To: garyj@gmx.de Cc: Mark Peek <mp@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 65904399db91 - main - efibootmgr: allow -u as a valid option Message-ID: <CAGGgMJenrGwEHNmN4jkPqsT6NwCQauQBm0JpLReFOsPK7Q31nw@mail.gmail.com> In-Reply-To: <20240325100136.2a052359@ernst.home> References: <202403241939.42OJdn3w018764@gitrepo.freebsd.org> <20240325100136.2a052359@ernst.home>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000217ac006147d1f01 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Mar 25, 2024 at 2:01=E2=80=AFAM Gary Jennejohn <garyj@gmx.de> wrote= : > On Sun, 24 Mar 2024 19:39:49 GMT > Mark Peek <mp@FreeBSD.org> wrote: > > > The branch main has been updated by mp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D65904399db9167b0970e42e14642e1d= 6bdbf6d3a > > > > commit 65904399db9167b0970e42e14642e1d6bdbf6d3a > > Author: Mark Peek <mp@FreeBSD.org> > > AuthorDate: 2024-03-24 19:37:12 +0000 > > Commit: Mark Peek <mp@FreeBSD.org> > > CommitDate: 2024-03-24 19:37:12 +0000 > > > > efibootmgr: allow -u as a valid option > > > > PR: 277907 > > Reported by: vsasjason@gmail.com > > MFC after: 1 week > > --- > > usr.sbin/efibootmgr/efibootmgr.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/usr.sbin/efibootmgr/efibootmgr.c > b/usr.sbin/efibootmgr/efibootmgr.c > > index 2bc79ee26f51..b919130d9c11 100644 > > --- a/usr.sbin/efibootmgr/efibootmgr.c > > +++ b/usr.sbin/efibootmgr/efibootmgr.c > > @@ -204,8 +204,8 @@ parse_args(int argc, char *argv[]) > > int ch; > > const char *arg; > > > > - while ((ch =3D getopt_long(argc, argv, > "AaBb:C:cdDe:EFfhk:L:l:NnOo:pTt:v", > > - lopts, NULL)) !=3D -1) { > > + while ((ch =3D getopt_long(argc, argv, > > + "AaBb:C:cdDe:EFfhk:L:l:NnOo:pTt:u:v", lopts, NULL)) !=3D -1) = { > > switch (ch) { > > case 'A': > > opts.set_inactive =3D true; > > > > -u is not documented in the man page for efibootmgr, although it was > already in the source. > > -- > Gary Jennejohn > Gary, I'm not sure I understand your comment. The man page was updated for -u in this commit: https://github.com/freebsd/freebsd-src/commit/9a7915299484a767fbffc7234b8dc= 45c29954cca And man shows this as: efibootmgr -u unix-path ... -u --efidev unix-path Displays the UEFI device path of unix-path. Mark --000000000000217ac006147d1f01 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr">On Mon, Mar 25, 2024 at 2:01=E2=80=AFAM G= ary Jennejohn <<a href=3D"mailto:garyj@gmx.de">garyj@gmx.de</a>> wrot= e:<br></div><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" st= yle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padd= ing-left:1ex">On Sun, 24 Mar 2024 19:39:49 GMT<br> Mark Peek <mp@FreeBSD.org> wrote:<br> <br> > The branch main has been updated by mp:<br> ><br> > URL: <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3D65904399db91= 67b0970e42e14642e1d6bdbf6d3a" rel=3D"noreferrer" target=3D"_blank">https://= cgit.FreeBSD.org/src/commit/?id=3D65904399db9167b0970e42e14642e1d6bdbf6d3a<= /a><br> ><br> > commit 65904399db9167b0970e42e14642e1d6bdbf6d3a<br> > Author:=C2=A0 =C2=A0 =C2=A0Mark Peek <mp@FreeBSD.org><br> > AuthorDate: 2024-03-24 19:37:12 +0000<br> > Commit:=C2=A0 =C2=A0 =C2=A0Mark Peek <mp@FreeBSD.org><br> > CommitDate: 2024-03-24 19:37:12 +0000<br> ><br> >=C2=A0 =C2=A0 =C2=A0efibootmgr: allow -u as a valid option<br> ><br> >=C2=A0 =C2=A0 =C2=A0PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= 277907<br> >=C2=A0 =C2=A0 =C2=A0Reported by:=C2=A0 =C2=A0 <a href=3D"mailto:vsasjas= on@gmail.com" target=3D"_blank">vsasjason@gmail.com</a><br> >=C2=A0 =C2=A0 =C2=A0MFC after:=C2=A0 =C2=A0 =C2=A0 1 week<br> > ---<br> >=C2=A0 usr.sbin/efibootmgr/efibootmgr.c | 4 ++--<br> >=C2=A0 1 file changed, 2 insertions(+), 2 deletions(-)<br> ><br> > diff --git a/usr.sbin/efibootmgr/efibootmgr.c b/usr.sbin/efibootmgr/ef= ibootmgr.c<br> > index 2bc79ee26f51..b919130d9c11 100644<br> > --- a/usr.sbin/efibootmgr/efibootmgr.c<br> > +++ b/usr.sbin/efibootmgr/efibootmgr.c<br> > @@ -204,8 +204,8 @@ parse_args(int argc, char *argv[])<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0int ch;<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0const char *arg;<br> ><br> > -=C2=A0 =C2=A0 =C2=A0while ((ch =3D getopt_long(argc, argv, "AaBb= :C:cdDe:EFfhk:L:l:NnOo:pTt:v",<br> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0lopts, = NULL)) !=3D -1) {<br> > +=C2=A0 =C2=A0 =C2=A0while ((ch =3D getopt_long(argc, argv,<br> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"AaBb:C:cdDe:EFfhk:L:l:NnOo:pT= t:u:v", lopts, NULL)) !=3D -1) {<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0switch (ch) {<br= > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0case 'A'= :<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0opts.set_inactive =3D true;<br> ><br> <br> -u is not documented in the man page for efibootmgr, although it was<br> already in the source.<br> <br> --<br> Gary Jennejohn<br></blockquote><div><br></div><div>Gary,</div><div>I'm = not sure I understand your comment. The man page was updated for -u in this= commit:</div><div><a href=3D"https://github.com/freebsd/freebsd-src/commit= /9a7915299484a767fbffc7234b8dc45c29954cca">https://github.com/freebsd/freeb= sd-src/commit/9a7915299484a767fbffc7234b8dc45c29954cca</a><br><br>And man s= hows this as:</div><div><font face=3D"monospace">=C2=A0 =C2=A0 =C2=A0efiboo= tmgr -u unix-path</font></div><div><font face=3D"monospace">=C2=A0 =C2=A0 = =C2=A0...</font></div><div><font face=3D"monospace">=C2=A0 =C2=A0 =C2=A0-u = --efidev unix-path<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Displ= ays the UEFI device path of unix-path.</font><br></div><div><br></div><div>= Mark</div></div></div> --000000000000217ac006147d1f01--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGGgMJenrGwEHNmN4jkPqsT6NwCQauQBm0JpLReFOsPK7Q31nw>