Date: Tue, 9 Feb 2021 10:19:24 +0100 From: Daniel Ebdrup Jensen <debdrup@FreeBSD.org> To: dev-commits-src-main@freebsd.org, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org> Subject: Re: git: 866c8b8d5ddb - main - kldload(8): Add note about using kld_list in rc.conf(5) Message-ID: <20210209091924.2llehdxlndekytkp@nerd-thinkpad.local> In-Reply-To: <20210208184822.uejqvgyl2ddv4emc@nerd-thinkpad.local> References: <202102080704.11874w7E017472@gitrepo.freebsd.org> <CANCZdfrJjBxDwM5gpccDbAJEhw_HBT7eq%2B2Tfd-kTxEo9_DitA@mail.gmail.com> <d9acb4ee-5ea4-b006-6fa0-86da8d369eda@grosbein.net> <CACNAnaF0xpfOodU=B4c91sA4za=-wfRgTY_MiJtr9TZuMNpoHw@mail.gmail.com> <f832f431-f151-bc47-948c-fded131e0766@grosbein.net> <CACNAnaFkywYo7bU8GyPYdTzCH4Xy-s4F38beBwJee5k4Odkdsg@mail.gmail.com> <33d6f518-2005-e859-0230-34490c3c5914@grosbein.net> <CACNAnaGte5LpzWJt1%2BfxYV%2BSKz9kMp13U4FyM0si%2BFcRQUytPA@mail.gmail.com> <20210208184822.uejqvgyl2ddv4emc@nerd-thinkpad.local>
next in thread | previous in thread | raw e-mail | index | archive | help
--wfpb4v3ij6dlmabh Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline On Mon, Feb 08, 2021 at 07:48:22PM +0100, Daniel Ebdrup Jensen wrote: >On Mon, Feb 08, 2021 at 09:22:25AM -0600, Kyle Evans wrote: >>On Mon, Feb 8, 2021 at 9:07 AM Eugene Grosbein <eugen@grosbein.net> wrote: >>> >>>08.02.2021 21:58, Kyle Evans wrote: >>> >>>>>>> kld_list cannot do that. >>>>>> >>>>>> Huh? kld_list accepts a full pathname, which is the same kind of >>>>>> specification you'd need to do with one from port in loader with >>>>>> *_name. >>>>> >>>>> Good, but seems to be undocumented. >>>>> >>>> >>>> In what sense? Is there some other place that kld_list is even >>>> documented than kldload(8)? >>> >>>Naturally: rc.conf(5), also in /etc/defaults/rc.conf >>> >> >>Wow, that documentation is just flat wrong for multiple reasons. >> >> kld_list (str) A whitespace-separated list of kernel modules to load >> right after the local disks are mounted, without any .ko >> extension or path. Loading modules at this point in the boot >> process is much faster than doing it via /boot/loader.conf >> for those modules not necessary for mounting local disks. >> >>The second part of the first sentence is a self-imposed limitation, >>and an incredibly unimportant one at that. Specifying a .ko will only >>break the existing "Is it loaded" behavior and cause it to always try, >>which is mostly a nuisance at best because it will get rejected if the >>kldstat inquiry is wrong -- the kld rc script will append .ko whether >>the path has one or not, so this should be fixed. Despite that, a path >>will work just fine for the most part; kldstat -v shows the fully >>qualified path. If it wanted to be improved, it just needs to basename >>what it was given to be able to detect if it was loaded from any other >>path and pass that in as the -e argument to load_kld if it really was >>a file. >> >>It's not wrong about loading modules being faster here, and at some >>point in the past it was even necessary due to loader(8) being too >>early or problematic in some terrible cases (e.g. nvidia modsetting >>bits), but the second half of that sentence should probably just be >>omitted or reworked to more vaguely refer to "... those modules not >>necessary for booting the system, including those required for >>mounting the root filesystem." The key changes being that there are >>other reasons you might need to load something early enough in boot, >>and that root isn't always a local disk. It's OK to call out the more >>common case for folks, but this feels a lot more absolute than it >>needs to be. >>_______________________________________________ >>dev-commits-src-main@freebsd.org mailing list >>https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main >>To unsubscribe, send any mail to "dev-commits-src-main-unsubscribe@freebsd.org" > >Hi folks, > >I'd originally replied to imp@ when he sent me a comment about this, >although because of a misconfiguration I hadn't seen it was also sent to >a different list, but in it I remarked the same things about >nvidia-modesetting and the speed, however I do think Kyle is right that >it's better to rework the sentence because mountroot isn't really >docuemented in the extant manual pages. > >I'm not sure about wanting to document the other details outlined here, >because I'm not entirely sure I understand them - plus, it's in a >different manual page, so it's free for anyone with an active commit bit >and an understanding to persue. :) > >I'll try and work something out and do a Phabricator review, but let's >try and keep the bike-shedding to a minimum. > >Yours, >Daniel Ebdrup Jensen > >P.S. We all know the best colour is purple. ;) Hi folks, For reference, the review is up at https://reviews.freebsd.org/D28542 and I've added a few people, who contacted me about this, to it. Yours, Daniel Ebdrup Jensen --wfpb4v3ij6dlmabh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAABCgB9FiEEDonNJPbg/JLIMoS6Ps5hSHzN87oFAmAiU5xfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDBF ODlDRDI0RjZFMEZDOTJDODMyODRCQTNFQ0U2MTQ4N0NDREYzQkEACgkQPs5hSHzN 87o63Af+I29+WGzQjR1DWcd1ROlzTJQllnO9EFZIRaav7MDiiFOwbI846554U0pQ 2bkITJo8GDpRPxyu0Qha67UA9dAR7IxznabapgodOGcrkLxExlhY9oGZiOt3WcfS SdrAIMlM7ADuHlUdqjBrNiltUaTVIzVmle+ZEPdqbYHZeOOvcC4QNitD3BuRG2iI tm8lmN/+DwIRAGHDprIJWpFdWke4b86rXw04TOlNofsKW5spNqUWOyrya0PZ0jbd EnzVUk9+ZgxWBRDIGnWrFeDCi1wc90D3DN/Bz2L3PWWxx/cCPNrrYgulw/1mCXrE Uh68Co50HZOGFaAeLFnNvcDNLkekZA== =6T5M -----END PGP SIGNATURE----- --wfpb4v3ij6dlmabh--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210209091924.2llehdxlndekytkp>