Date: Mon, 7 May 2018 10:28:13 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Warner Losh <imp@bsdimp.com> Cc: "Conrad E. Meyer" <cem@freebsd.org>, "Rodney W. Grimes" <rgrimes@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333324 - in head/sys: amd64/amd64 conf Message-ID: <201805071728.w47HSDuD056876@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <CANCZdfrJUuy5OnYM-%2BopNmnCoJsx6y=oRLOD41rHyXOfUjS4Rw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[ Charset UTF-8 unsupported, converting... ] > On Mon, May 7, 2018 at 10:26 AM, Conrad Meyer <cem@freebsd.org> wrote: > > > On Mon, May 7, 2018 at 8:45 AM, Rodney W. Grimes > > <freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > >> + * ws@tools.de (Wolfgang Solfrank, TooLs GmbH) +49-228-985800 > > > > > > If the original is by ws@tools.de, who is this version by? > > > Or is this simply copied from some other FreeBSD file? > > > > This is covered thoroughly in lines 1-10 of the commit email: > > > > > Author: mjg > > ... > > > memmove is repurposed bcopy (arguments swapped, return value added) > > > > It's also trivial to see from code comparison... It noticed it right away > while reviewing... I believe both you and Conrad are placing to much weight on the commit message and no weight on the comment. Someone reading the code is not going to have the context we presently have. Comments in code need to stand alone, without any context of commit message creating them, or code else where, unless they directly reference that code else where. -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201805071728.w47HSDuD056876>