Date: Sat, 6 Apr 2002 17:06:22 -0800 From: Brooks Davis <brooks@one-eyed-alien.net> To: Julian Elischer <julian@elischer.org> Cc: Brooks Davis <brooks@one-eyed-alien.net>, net@FreeBSD.ORG Subject: Re: review request: minor cloning API change Message-ID: <20020406170622.B6096@Odin.AC.HMC.Edu> In-Reply-To: <Pine.BSF.4.21.0204061639400.43363-100000@InterJet.elischer.org>; from julian@elischer.org on Sat, Apr 06, 2002 at 04:44:32PM -0800 References: <20020405230719.A13516@Odin.AC.HMC.Edu> <Pine.BSF.4.21.0204061639400.43363-100000@InterJet.elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Sat, Apr 06, 2002 at 04:44:32PM -0800, Julian Elischer wrote: > Please excuse the comment if I'm way off the mark.. > > With a VERY BRIEF look I see that you are returning a void > from the destroy function and it is callled from the module unload code > where some destroy functions used to return ints. > > this ia I think a BAD MOVE.. > > a driver must be able to veto it's own unloading. > If it is in use fro example. You leave no way for the driver to say > "Nope, I can't be unloaded now, I'm busy." NetBSD does it this way and we did so too until a few weeks ago. I'm just returing to the old behavior. The unload of the loopback interface still fails as is required by the system. -- Brooks -- Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE8r5uNXY6L6fI4GtQRAsVGAKCusHLJ6YyUmSQn1M673jHdeqOQsACeM8BM TuEM192xapvCTxcGWwjYIuM= =5CML -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020406170622.B6096>