Date: Tue, 25 May 2010 21:39:23 -0700 From: Tim Kientzle <kientzle@freebsd.org> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: stable@freebsd.org, Martin Matuska <mm@freebsd.org> Subject: Re: lzma support in `stable' has potential issues Message-ID: <4BFCA5FB.80109@freebsd.org> In-Reply-To: <8A12D1D8-7D3D-472A-8B2B-637D3E243D56@gmail.com> References: <8A12D1D8-7D3D-472A-8B2B-637D3E243D56@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
It would be nice if "cd /usr/src/lib/liblzma && make && make install"
just worked on an existing system that didn't already have
/usr/include/lzma, but I can't find anything in the
standard BSD makefiles to support this.
I think you can use:
make hierarchy
to ensure that all the directories are present before
trying to build anything else. (This is one of the
first steps in the "installworld" target.)
As for lzmainfo, I think the attached patch fixes
it so that it pulls the lzma headers from the source
tree and not the installed system. A similar change
is probably appropriate for the other lzma and xz tools.
Tim
Garrett Cooper wrote:
> Hi Martin and Tim,
> I recently wiped off my Lenovo again to get a fresh install of FreeBSD on it, and started out at 8.0-RELEASE (it's the media that I had on hand at the time). Upgrading to 8-STABLE appears to be problematic though.
> On a few different occasions I ran into issues doing the following:
>
> make -C /usr/src/usr.bin/lzmainfo depend - fails to find the appropriate headers
>
> make -C /usr/src/lib/liblzma install - fails to install the headers into /usr/include/lzma
>
> Etc. I didn't see these issues before lzma was imported into the tree, which makes me wonder whether or not there are some missing build or install dependencies somewhere.
> Thanks,
> -Garrett
>
[-- Attachment #2 --]
Index: Makefile
===================================================================
--- Makefile (revision 208369)
+++ Makefile (working copy)
@@ -3,7 +3,6 @@
PROG= lzmainfo
XZDIR= ${.CURDIR}/../../contrib/xz/src
-LZMALIBDIR= ${.CURDIR}/../../lib/liblzma
.PATH: ${XZDIR}/lzmainfo
SRCS+= lzmainfo.c
@@ -14,9 +13,10 @@
WARNS?= 3
-CFLAGS+= -DHAVE_CONFIG_H \
- -I${LZMALIBDIR} \
- -I${XZDIR}/common
+CFLAGS+= -DHAVE_CONFIG_H
+CFLAGS+= -I${.CURDIR}/../../lib/liblzma
+CFLAGS+= -I${.CURDIR}/../../contrib/xz/src/liblzma/api
+CFLAGS+= -I${XZDIR}/common
DPADD= ${LIBLZMA}
LDADD= -llzma
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4BFCA5FB.80109>