Date: Wed, 3 Oct 2018 14:39:49 +0100 From: Johannes Lundberg <johalun0@gmail.com> To: Jakob Alvermark <jakob@alvermark.net> Cc: freebsd-current <freebsd-current@freebsd.org> Subject: Re: Sound issues with Dell Latitude 7490 (kabylake) Message-ID: <CAECmPws63Pn9J4uxrrvjfa%2B9f5JWp4eRxhB93V-FB1O1e3RU%2Bg@mail.gmail.com> In-Reply-To: <a8f4cc37-8639-ab64-b3cb-4239127f9e43@alvermark.net> References: <CAECmPws%2BqW0-zy0ucN0JSDEX=JLpAHm=AbXJYRJ-Mejnoy4ecA@mail.gmail.com> <85518f55-20a8-f534-7266-a9e847912afc@alvermark.net> <CAECmPwvqaWbWDu7TVpYxxTr7-Zr=RWnUWi1C=8S=TOmrBKdpZg@mail.gmail.com> <596a89fa-d7a3-1d39-d296-e07359cb487f@alvermark.net> <20181003130645.GH1118@albert.catwhisker.org> <a8f4cc37-8639-ab64-b3cb-4239127f9e43@alvermark.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Wed, Oct 3, 2018 at 2:30 PM Jakob Alvermark <jakob@alvermark.net> wrote:
> On 10/3/18 3:06 PM, David Wolfskill wrote:
> > On Mon, Oct 01, 2018 at 11:12:25PM +0200, Jakob Alvermark wrote:
> >> ....
> >> Do the headphones work with this patch?
> >>
> >> Index: sys/dev/sound/pci/hda/hdaa.c
> >> ===================================================================
> >> --- sys/dev/sound/pci/hda/hdaa.c (revision 339076)
> >> +++ sys/dev/sound/pci/hda/hdaa.c (working copy)
> >> @@ -5034,11 +5034,13 @@
> >> pincap = w->wclass.pin.cap;
> >>
> >> /* Disable everything. */
> >> + /*
> >> w->wclass.pin.ctrl &= ~(
> >> HDA_CMD_SET_PIN_WIDGET_CTRL_HPHN_ENABLE |
> >> HDA_CMD_SET_PIN_WIDGET_CTRL_OUT_ENABLE |
> >> HDA_CMD_SET_PIN_WIDGET_CTRL_IN_ENABLE |
> >> HDA_CMD_SET_PIN_WIDGET_CTRL_VREF_ENABLE_MASK);
> >> + */
> >>
> >> if (w->enable == 0) {
> >> /* Pin is unused so left it disabled. */
> >> ....
> > Thank you! This addressed the long-standing (Reported: 2015-05-29
> > 21:15 UTC) issue I have had with my laptop (Dell Precision M4800), as
> > documented in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200526
> > -- now updated to reflect the fix.
>
>
> That's great! Glad to hear it helped.
>
> This is probably not a proper fix, but it helps to understand the problem.
>
> Could you post the output of 'sysctl dev.hdaa' with and without the
> patch so we can see what's different?
>
>
Hi Jakob
Here's my diff from orig to patched (full output zipped and attached)
johannes@jm:~ % diff -u -U5 tmp/dev_hdaa_0_orig.txt
tmp/dev_hdaa_0_patched.txt
--- tmp/dev_hdaa_0_orig.txt 2018-10-03 14:32:31.264778000 +0100
+++ tmp/dev_hdaa_0_patched.txt 2018-10-03 14:28:18.767561000 +0100
@@ -58,11 +58,11 @@
dev.hdaa.0.nid30_config: 0x421212f2 as=15 seq=2 device=Speaker conn=None
ctype=1/4 loc=Front color=Black misc=2
dev.hdaa.0.nid30: pin: Speaker (None) [DISABLED]
Widget cap: 0x00400781 PWR DIGITAL UNSOL STEREO
Pin cap: 0x00000014 PDC OUT
Pin config: 0x421212f2 as=15 seq=2 device=Speaker conn=None ctype=1/4
loc=Front color=Black misc=2
- Pin control: 0x00000000
+ Pin control: 0x00000040 OUT
Connections: 1
+ <- nid=6 [audio output] [DISABLED]
dev.hdaa.0.nid29_original: 0x40700001 as=0 seq=1 device=Modem-handset
conn=None ctype=Unknown loc=0x00 color=Unknown misc=0
dev.hdaa.0.nid29_config: 0x40700001 as=0 seq=1 device=Modem-handset
conn=None ctype=Unknown loc=0x00 color=Unknown misc=0
@@ -81,11 +81,11 @@
dev.hdaa.0.nid27_config: 0x411111f0 as=15 seq=0 device=Speaker conn=None
ctype=1/8 loc=Rear color=Black misc=1
dev.hdaa.0.nid27: pin: Speaker (None) [DISABLED]
Widget cap: 0x0040058f PWR UNSOL STEREO
Pin cap: 0x00013734 PDC OUT IN VREF[ 50 80 100 GROUND HIZ ] EAPD
Pin config: 0x411111f0 as=15 seq=0 device=Speaker conn=None ctype=1/8
loc=Rear color=Black misc=1
- Pin control: 0x00000000
+ Pin control: 0x00000020 IN
EAPD: 0x00000002 EAPD
Output amp: 0x80000000 mute=1 step=0 size=0 offset=0 (0/0dB)
Input amp: 0x00270300 mute=0 step=3 size=39 offset=0 (0/30dB)
Connections: 2
+ [DISABLED] <- nid=2 [audio output] (selected)
@@ -104,20 +104,20 @@
dev.hdaa.0.nid25_config: 0x411111f0 as=15 seq=0 device=Speaker conn=None
ctype=1/8 loc=Rear color=Black misc=1
dev.hdaa.0.nid25: pin: Speaker (None) [DISABLED]
Widget cap: 0x0040048b PWR UNSOL STEREO
Pin cap: 0x00003724 PDC IN VREF[ 50 80 100 GROUND HIZ ]
Pin config: 0x411111f0 as=15 seq=0 device=Speaker conn=None ctype=1/8
loc=Rear color=Black misc=1
- Pin control: 0x00000000
+ Pin control: 0x00000020 IN
Input amp: 0x00270300 mute=0 step=3 size=39 offset=0 (0/30dB)
dev.hdaa.0.nid24_original: 0x411111f0 as=15 seq=0 device=Speaker conn=None
ctype=1/8 loc=Rear color=Black misc=1
dev.hdaa.0.nid24_config: 0x411111f0 as=15 seq=0 device=Speaker conn=None
ctype=1/8 loc=Rear color=Black misc=1
dev.hdaa.0.nid24: pin: Speaker (None) [DISABLED]
Widget cap: 0x0040048b PWR UNSOL STEREO
Pin cap: 0x00003724 PDC IN VREF[ 50 80 100 GROUND HIZ ]
Pin config: 0x411111f0 as=15 seq=0 device=Speaker conn=None ctype=1/8
loc=Rear color=Black misc=1
- Pin control: 0x00000000
+ Pin control: 0x00000020 IN
Input amp: 0x00270300 mute=0 step=3 size=39 offset=0 (0/30dB)
dev.hdaa.0.nid23: vendor widget [DISABLED]
Widget cap: 0x00f00000
> Jakob
>
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
>
[-- Attachment #2 --]
PK tCMԕg D* dev_hdaa_0_orig.txtUT Ĵ[Ĵ[ux Z[o8~8/+Qtv)ݶ H[Fib:Q!fй=qȍRhJM& 8WDzޒ>7u;@ %}Q>vIT81BXw3`#[=UNNo >oGO5NI&5ṎwZ:ϸ
lkNB%& gCYv^(R Փk8t`.<7{*<`,SW=]jEW
s;w?C+n >˳UvRXк GGE 9%+`wY, }YsY$eȻpt]MLEq}K'tr[,h/b 8wؾVZ%212hd؏ ŁU߽w=k&G1Jq
8Xy[+ ݲ ,pޙ0v @̄}?x# v @fLjhOc /7@<r!6p1G8G#),i^6I֭ip(Ɏm k<k>1<r~"1mJ"Fh<<-#dԨ2S&ɠI6 iDL SL`ek5/b>m hTJ?0ػ,K,Hy݊y FHYJyyC:Gڟ+WsBnO|dϢ& K;e;֪9cHD)G"7Rn&z +uX86r,nP.Č<htMIF=dzj-, Zvw{G'͜V'
ɀb(oA#`L>7}7f
@c[j =(к-c $v΄"C~f{բ7}osBj٢H^"Z,ҚeʢX6"Y,jEJMy^
;5Y~& &L@dzXWx!cU^mvݨߢ^:6' 印u)=(5m rYKK
ձO ko_74kY~VkCuMBt엚WtTX (]
j) c2ZPdד\h% ˴fLTɎV &;5%Q$֔DQRvzJVn3F~ܚG(N<ʼD1Io@UA5m3熣lLD0, SuBMTdKMy Զ_~ڳ3rړSTz_NIVKi7f+I9B E:ul܊lOIhf(
hڻM|_w`0r=_
v ?6ɿ0T]ėwt1Ǐ0D1I+GKWV5 .OCOғ>b8PK sCM|> Q* dev_hdaa_0_patched.txtUT ô[ô[ux Z[o8~8/+Qtv)ݶ H[Fib:Q!fй=qȍRhJM& ?8WDzޒ>7u;@ %}Q>vIT81BXw3`#[=UNNo >oGO5NI&5ṎwZ:ϸ
lkNB%& gCYv^(R Փk8t`.<7{*<`,SW=]jEW
s;w?C+n >˳UvRXк GGhi ϖbq[/k.$` yK pr4!>;?.FI&,- ڋ-/`]DorV +Cq`/w]ϚɑcR =.7Vpm$u w&̄= 3wϢs7s5;$ 4HG ed 3&[qq5UB4Ӂѧ1\O}T u" PFS#Fu#),i^6I֭ipHɎmk<k>1<r~B9mJ"Dh<<-#dب2S&I4 iFH
SH`ek5/!b>mR0bawYdvTIt;H7r
ѓ#ZXf<l!{ u9$ӕp9ABnO|d6'K̬;f=w 3UƐЉpS',B)>M=Jו:l86,nP1\f=9y蚒 vų[~@0흡4sZ-*b(̄oA#`@ Û>\ !U
rj;@b JlAiL(QBcw 7K}o¨s CńB'ԂbQ5"Em@R,W 5$&AJNMp_ 5d#S=Vr4 r^}X%K.[L
\ǮX+DA6zrwv@QQK{ IVKUVg@u,i~ߔgxmFO,Ɇ%5 yґ_j_Pb}"vM66& r]u<mt4/QϤLh5QkS5(Z ;ٕfF ~ܚG(N<ʼDQ@PUPMh@ \)Sj~=! KhPc^U^ T sOm>'u@(N IU,Z/O^
C!jf.pv4I4G(GQN $&0[~) ЌZ0։TuV"J-9\l8.,,{am+uTt@JAt_? ?RLbR;Wb&;w /]Y<;0,л<e=9VKOf
PK tCMԕg D* dev_hdaa_0_orig.txtUT Ĵ[ux PK sCM|> Q* @ dev_hdaa_0_patched.txtUT ô[ux PK
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAECmPws63Pn9J4uxrrvjfa%2B9f5JWp4eRxhB93V-FB1O1e3RU%2Bg>