Date: Mon, 26 Jul 2010 01:36:07 +1000 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Stefan Farfeleder <stefanf@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Konstantin Belousov <kib@freebsd.org> Subject: Re: svn commit: r210451 - head/sys/sys Message-ID: <20100726013202.G11808@delplex.bde.org> In-Reply-To: <20100724183732.GA1715@mole.fafoe.narf.at> References: <201007241814.o6OIEY4K099556@svn.freebsd.org> <20100724183732.GA1715@mole.fafoe.narf.at>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 24 Jul 2010, Stefan Farfeleder wrote:
> declaring enums like this is not standard C code (seems to be a GCC
> extension). I don't think we should use this feature in our headers.
This is unfortunate. This is because the size of an enum variable
depends on its complete declaration. This is an error unconditionaly
with TenDRA. It takes -pedantic to get a warning from gcc.
>> Modified: head/sys/sys/imgact.h
>> ==============================================================================
>> --- head/sys/sys/imgact.h Sat Jul 24 18:05:10 2010 (r210450)
>> +++ head/sys/sys/imgact.h Sat Jul 24 18:14:34 2010 (r210451)
>> @@ -32,8 +32,6 @@
>> #ifndef _SYS_IMGACT_H_
>> #define _SYS_IMGACT_H_
>>
>> -#include <sys/uio.h>
>> -
The rule that new pollution may not be added to old headers should have
prevented the need for this removal.
>> #define MAXSHELLCMDLEN PAGE_SIZE
>>
>> struct image_args {
>> @@ -75,6 +73,7 @@ struct image_params {
>> #ifdef _KERNEL
>> struct sysentvec;
>> struct thread;
>> +enum uio_seg;
>>
>> #define IMGACT_CORE_COMPRESS 0x01
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100726013202.G11808>