Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 13 Aug 2019 20:56:44 +0000 (UTC)
From:      Kirk McKusick <mckusick@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r351002 - head/sys/ufs/ffs
Message-ID:  <201908132056.x7DKui5t010714@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mckusick
Date: Tue Aug 13 20:56:44 2019
New Revision: 351002
URL: https://svnweb.freebsd.org/changeset/base/351002

Log:
  Clarify comment that describes how the FS_METACKHASH is managed.
  
  MFC after: 3 days

Modified:
  head/sys/ufs/ffs/fs.h

Modified: head/sys/ufs/ffs/fs.h
==============================================================================
--- head/sys/ufs/ffs/fs.h	Tue Aug 13 20:06:55 2019	(r351001)
+++ head/sys/ufs/ffs/fs.h	Tue Aug 13 20:56:44 2019	(r351002)
@@ -409,22 +409,27 @@ CTASSERT(sizeof(struct fs) == 1376);
  * The FS_UNCLEAN flag is set by the kernel when the filesystem was
  * mounted with fs_clean set to zero. The FS_DOSOFTDEP flag indicates
  * that the filesystem should be managed by the soft updates code.
- * Note that the FS_NEEDSFSCK flag is set and cleared only by the
- * fsck utility. It is set when background fsck finds an unexpected
+ * Note that the FS_NEEDSFSCK flag is set and cleared by the fsck
+ * utility. It is set when background fsck finds an unexpected
  * inconsistency which requires a traditional foreground fsck to be
  * run. Such inconsistencies should only be found after an uncorrectable
- * disk error. A foreground fsck will clear the FS_NEEDSFSCK flag when
- * it has successfully cleaned up the filesystem. The kernel uses this
+ * disk error. The FS_NEEDSFSCK can also be set when a mounted filesystem
+ * discovers an internal inconsistency such as freeing a freed inode.
+ * A foreground fsck will clear the FS_NEEDSFSCK flag when it has
+ * successfully cleaned up the filesystem. The kernel uses this
  * flag to enforce that inconsistent filesystems be mounted read-only.
- * The FS_INDEXDIRS flag when set indicates that the kernel maintains
- * on-disk auxiliary indexes (such as B-trees) for speeding directory
- * accesses. Kernels that do not support auxiliary indices clear the
- * flag to indicate that the indices need to be rebuilt (by fsck) before
- * they can be used. When a filesystem is mounted, any flags not
- * included in FS_SUPPORTED are cleared. This lets newer features
- * know that the filesystem has been run on an older version of the
- * filesystem and thus that data structures associated with those
- * features are out-of-date and need to be rebuilt.
+ *
+ * The FS_METACKHASH flag when set indicates that the kernel maintains
+ * one or more check hashes. The actual set of supported check hashes
+ * is stored in the fs_metackhash field. Kernels that do not support
+ * check hashes clear the FS_METACKHASH flag to indicate that the
+ * check hashes need to be rebuilt (by fsck) before they can be used.
+ *
+ * When a filesystem is mounted, any flags not included in FS_SUPPORTED
+ * are cleared. This lets newer features know that the filesystem has
+ * been run on an older version of the filesystem and thus that data
+ * structures associated with those features are out-of-date and need
+ * to be rebuilt.
  *
  * FS_ACLS indicates that POSIX.1e ACLs are administratively enabled
  * for the file system, so they should be loaded from extended attributes,



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201908132056.x7DKui5t010714>