Date: Mon, 27 Jan 2003 14:24:16 -0800 From: David Schultz <dschultz@uclink.Berkeley.EDU> To: Enache Adrian <enache@rdslink.ro> Cc: current@FreeBSD.ORG Subject: Re: boot delay when testing for ata devices Message-ID: <20030127222416.GA375@HAL9000.homeunix.com> In-Reply-To: <20030127221825.GA903@ratsnest.hole> References: <20030127221825.GA903@ratsnest.hole>
next in thread | previous in thread | raw e-mail | index | archive | help
Thus spake Enache Adrian <enache@rdslink.ro>:
> FreeBSD used to have an irritating boot delay in 4.4. It was gone in
> ~4.6, never reappeared in -STABLE, but is there in -CURRENT.
> (I've seen it also mentioned in some vmware documentation).
>
> Applying this patch fixes it:
>
> --- /arc/freebsd/src/sys/dev/ata/ata-all.c Sun Jan 19 23:54:13 2003
> +++ sys/dev/ata/ata-all.c Mon Jan 27 21:02:34 2003
> @@ -514,7 +514,7 @@
>
> /* apparently some devices needs this repeated */
> do {
> - if (ata_command(atadev, command, 0, 0, 0, ATA_WAIT_INTR)) {
> + if (ata_command(atadev, command, 0, 0, 0, ATA_IMMEDIATE)) {
> ata_prtdev(atadev, "%s identify failed\n",
> command == ATA_C_ATAPI_IDENTIFY ? "ATAPI" : "ATA");
> free(ata_parm, M_ATA);
>
> I'm not familiar with the ata code, but I can't see from ata-all.c
> which harm this could cause.
There is already at least one person for whom this code doesn't
work, so this patch doesn't seem like a good idea. Someone needs
to figure out exactly what delays are needed here to make
everyone's hardware actually work.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030127222416.GA375>