Date: Sun, 2 Aug 2026 07:56:17 -0700 From: Mark Millard <marklmi@yahoo.com> To: Robert Clausecker <fuz@FreeBSD.org>, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Faraz Vahedi <kfv@kfv.io> Subject: Re: git: 296c05f7212c - main - libutil++: Include <cerrno> in stringf.cc Message-ID: <9106cdc6-f040-49b3-97fd-2d3ddef4d283@yahoo.com> In-Reply-To: <6a6f33c9.1d959.1a21c17@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
On 8/2/26 05:10, Robert Clausecker wrote: > The branch main has been updated by fuz: > > URL: https://cgit.FreeBSD.org/src/commit/?id=296c05f7212c37bd6e6bf7e42af11d42a275d493 > > commit 296c05f7212c37bd6e6bf7e42af11d42a275d493 > Author: Faraz Vahedi <kfv@kfv.io> > AuthorDate: 2026-05-11 06:05:18 +0000 > Commit: Robert Clausecker <fuz@FreeBSD.org> > CommitDate: 2026-08-02 11:17:45 +0000 > > libutil++: Include <cerrno> in stringf.cc > > stringf.cc uses errno and related macros without including <cerrno>. > > Their availability is guaranteed only when the corresponding header > is included; transitive exposure is implementation-defined. > > Modern libc++ has been progressively reducing incidental transitive > includes as part of its header removal policy (see LLVM libc++ Header > Removal Policy and D132284), making such dependencies brittle. > > This change includes <cerrno> explicitly to make the dependency > well-defined. No functional or behavioural change intended. > > Approved by: fuz > Signed-off-by: Faraz Vahedi <kfv@kfv.io> > Pull-Request: https://github.com/freebsd/freebsd-src/pull/2188 > --- > lib/libutil++/libutil++.hh | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/libutil++/libutil++.hh b/lib/libutil++/libutil++.hh > index 60e6b3fc5fde..3ba46ed5c506 100644 > --- a/lib/libutil++/libutil++.hh > +++ b/lib/libutil++/libutil++.hh > @@ -13,6 +13,7 @@ > #include <netdb.h> > #include <unistd.h> > > +#include <cerrno> > #include <cstdarg> > #include <cstdio> > #include <cstdlib> > > Will this be MFC'd ? -- === Mark Millard marklmi at yahoo.comhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9106cdc6-f040-49b3-97fd-2d3ddef4d283>