Date: Mon, 24 Jun 2024 16:07:56 -0600 From: Warner Losh <imp@bsdimp.com> To: Gleb Smirnoff <glebius@freebsd.org> Cc: Justin Hibbits <jhibbits@freebsd.org>, Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: c2e9c5bbf022 - main - tpm: Refactor TIS and add a SPI attachment Message-ID: <CANCZdfqrX9FtdDmZScWn6MNwwD0WRxjzJo9Z93Wcn5qM_rLfug@mail.gmail.com> In-Reply-To: <ZnniHBI7bg--g8pV@cell.glebi.us> References: <202405032032.443KWhf0045034@gitrepo.freebsd.org> <ZnnMBXi2sGdtc_67@cell.glebi.us> <20240624161128.33c0f518@ralga.knownspace> <ZnniHBI7bg--g8pV@cell.glebi.us>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Mon, Jun 24, 2024, 3:16 PM Gleb Smirnoff <glebius@freebsd.org> wrote: > On Mon, Jun 24, 2024 at 04:11:28PM -0400, Justin Hibbits wrote: > J> > sorry for late notice, but we just discovered that after this commit > J> > tpm(4) on ACPI no longer attaches. From what I see ther probe method > J> > isn't even called. > J> > J> Hi Gleb, > J> > J> That's very odd. The probe method hasn't changed, nor has the tpm_acpi > J> attachment (still acpi), so I'm really confused why it wouldn't be > J> called now. Is there any debugging you can do to further narrow it > J> down? I haven't seen any issues reported internally at Juniper on x86 > J> hardware. I just verified everything should get built properly. > > I started adding printfs to the probe method and as said - it is not > even called. So I puzzled on where to start the debugging. I can test > patches/ideas if you have any. > > Warner is also looking into this problem. > I'm looking at name mismatched and/or moved parents to see if that's in play. I thought I'd found something like this earlier, but it was a false alarm I think. Warner > [-- Attachment #2 --] <div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jun 24, 2024, 3:16 PM Gleb Smirnoff <<a href="mailto:glebius@freebsd.org">glebius@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Mon, Jun 24, 2024 at 04:11:28PM -0400, Justin Hibbits wrote:<br> J> > sorry for late notice, but we just discovered that after this commit<br> J> > tpm(4) on ACPI no longer attaches. From what I see ther probe method<br> J> > isn't even called.<br> J> <br> J> Hi Gleb,<br> J> <br> J> That's very odd. The probe method hasn't changed, nor has the tpm_acpi<br> J> attachment (still acpi), so I'm really confused why it wouldn't be<br> J> called now. Is there any debugging you can do to further narrow it<br> J> down? I haven't seen any issues reported internally at Juniper on x86<br> J> hardware. I just verified everything should get built properly.<br> <br> I started adding printfs to the probe method and as said - it is not<br> even called. So I puzzled on where to start the debugging. I can test<br> patches/ideas if you have any.<br> <br> Warner is also looking into this problem.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">I'm looking at name mismatched and/or moved parents to see if that's in play. I thought I'd found something like this earlier, but it was a false alarm I think.</div><div dir="auto"><br></div><div dir="auto">Warner</div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"></blockquote></div></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> </blockquote></div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqrX9FtdDmZScWn6MNwwD0WRxjzJo9Z93Wcn5qM_rLfug>