Date: Tue, 09 Jun 2026 11:51:27 +0000 From: Tai-hwa Liang <avatar@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 8011f6b0d8ba - main - if_axge: remove AXGE_RX_MII_ERR from packet dropping criteria Message-ID: <6a27fe3f.3866b.5589aeb1@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch main has been updated by avatar: URL: https://cgit.FreeBSD.org/src/commit/?id=8011f6b0d8ba2ee18a60f3bd719f950081a474b3 commit 8011f6b0d8ba2ee18a60f3bd719f950081a474b3 Author: Tai-hwa Liang <avatar@FreeBSD.org> AuthorDate: 2026-05-15 14:32:03 +0000 Commit: Tai-hwa Liang <avatar@FreeBSD.org> CommitDate: 2026-06-09 11:51:09 +0000 if_axge: remove AXGE_RX_MII_ERR from packet dropping criteria Packets received with the following configuration are associated with AXGE_RX_MII_ERR, which looks legit since there's no AXGE_RX_CRC_ERR or AXGE_RX_DROP_PKT attached: axge0: <ASIX Elec. Corp. AX88179, rev 2.10/1.00, addr 3> on usbus0 miibus0: <MII bus> on axge0 rgephy0: <RTL8169S/8110S/8211 1000BASE-T media interface> PHY 3 on miibus0 rgephy0: OUI 0x00e04c, model 0x0011, rev. 5 rgephy0: none, 10baseT, 10baseT-FDX, 10baseT-FDX-flow, 100baseTX, 100baseTX-FDX, 100baseTX-FDX-flow, 1000baseT-FDX, 1000baseT-FDX-master, 1000baseT-FDX-flow, 1000baseT-FDX-flow-master, auto, auto-flow Without this, 'dhclient ue0' never gets valid lease as all the DHCP replies are dropped by the driver. This behaviour is align with the reference driver provided by the vendor(ASIX_USB_NIC_Linux_Driver_Source_v3.5.0.tar.bz2). MFC after: 2 weeks --- sys/dev/usb/net/if_axgereg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/usb/net/if_axgereg.h b/sys/dev/usb/net/if_axgereg.h index 87e662b6cbc1..5cc9edeaf3b8 100644 --- a/sys/dev/usb/net/if_axgereg.h +++ b/sys/dev/usb/net/if_axgereg.h @@ -197,7 +197,7 @@ struct axge_frame_rxhdr { #define AXGE_RXBYTES(x) (((x) & AXGE_RX_LEN_MASK) >> AXGE_RX_LEN_SHIFT) #define AXGE_RX_ERR(x) \ - ((x) & (AXGE_RX_CRC_ERR | AXGE_RX_MII_ERR | AXGE_RX_DROP_PKT)) + ((x) & (AXGE_RX_CRC_ERR | AXGE_RX_DROP_PKT)) struct axge_softc { struct usb_ether sc_ue;home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a27fe3f.3866b.5589aeb1>