Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 5 Jun 2012 16:48:47 +0400
From:      Andrey Chernov <ache@FreeBSD.ORG>
To:        Konstantin Belousov <kostikbel@gmail.com>
Cc:        svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, src-committers@FreeBSD.ORG, Dimitry Andric <dim@FreeBSD.ORG>
Subject:   Re: svn commit: r236582 - head/lib/libc/stdlib
Message-ID:  <20120605124847.GB13306@vniz.net>
In-Reply-To: <20120605083553.GH85127@deviant.kiev.zoral.com.ua>
References:  <201206042134.q54LYoVJ067685@svn.freebsd.org> <4FCDBE69.6080906@FreeBSD.org> <20120605083553.GH85127@deviant.kiev.zoral.com.ua>

next in thread | previous in thread | raw e-mail | index | archive | help

--qDbXVdCdHGoSgWSk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 05, 2012 at 11:35:53AM +0300, Konstantin Belousov wrote:
> Not to mention that the patch was committed to _our_ implementation of
> libc, which uses _our_ free, and not some abstract free(3). Our free chan=
ging
> errno means that process state is so messed that worrying about realpath(=
3)
> correctness is beyond any expectations.

We can't stay with "our free" concept but with "some abstract free"=20
instead. The code must be portable and even "our free" can be replaced in=
=20
the future.

About errno changing, look at "our free" code pass, potential candidates=20
(as Garrett mentions) are utrace, assert, idalloc - I don't look deep to=20
say for sure. But it does not really matter because the whole "our free"=20
concept is flawed.

> I already described my POV to ache, but it seems that nobody listens. It =
just
> a season, it seems.

You deside to not answer to the free() discussion which follows your=20
initial commit, which means either you agree with change or you are not=20
interested. It looks strange that you just consider to answer now and keep=
=20
silence at the time of discussion.

--=20
http://ache.vniz.net/

--qDbXVdCdHGoSgWSk
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAk/OAC8ACgkQVg5YK5ZEdN2BOwCgqT9ce0JL6k9QvfXN6DjGP87x
xFEAnRZQAuX2VFJsrT9WzRGguCHO9d2E
=uKtO
-----END PGP SIGNATURE-----

--qDbXVdCdHGoSgWSk--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120605124847.GB13306>