Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 22 Sep 2020 02:31:29 +0000
From:      Rick Macklem <rmacklem@uoguelph.ca>
To:        "freebsd-current@freebsd.org" <freebsd-current@freebsd.org>
Subject:   review of mountd.c change
Message-ID:  <YTBPR01MB39667D6CBE541525B2F9728DDD3B0@YTBPR01MB3966.CANPRD01.PROD.OUTLOOK.COM>
index | next in thread | raw e-mail 

Hi,

I just put a patch up in phabricator (D26521) which avoids always
malloc()'ng a large MAX_NGROUPS sized groups list by having a
small one in the structure and then only malloc()'ng when a large
groups list is needed.

I've listed kib@ and freqlabs@ as reviewers, but anyone else is
welcome to review it.

The review is probably about the technique I used.
(Alternately, the could just always malloc() the groups array the
 correct size instead of using the SMALLNGROUPS one or malloc()'ng.)

Thanks in advance to anyone that reviews it, rick
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YTBPR01MB39667D6CBE541525B2F9728DDD3B0>