Date: Sat, 17 Aug 2024 15:41:30 +0200 From: Nicola Vitale <nicola.stanislao.vitale@gmail.com> To: Gleb Popov <arrowd@freebsd.org>, Nicola Vitale <nivit@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: d191d48e545e - main - x11/kitty: Fix pkg-plist when DOCS option is off Message-ID: <7ad037a5-a92c-455e-b54c-9287e4fe5749@gmail.com> In-Reply-To: <CALH631kWKg1o8MmU=TZcPO7%2B5vOAAdOj1XpJSAyN1G-EEAKOPA@mail.gmail.com> References: <202408170839.47H8d1f6010111@gitrepo.freebsd.org> <CALH631kWKg1o8MmU=TZcPO7%2B5vOAAdOj1XpJSAyN1G-EEAKOPA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------5LHIk79tUfiAurjaWEGNB1UE Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, thanks for the advice, but [1] the option MANPAGES is not present in the Porter's Handbook, and the section 5.12 (Man pages) says only that "manual pages must be placed in pkg-plist along with the rest of the files". This distinction between man pages and other docs is misleading in my opinion. "What are docs?" [2] Furthermore, x11/kitty is not the only one that uses %%PORTDOCS%%/share/man in pkg-plist, and NO_INSTALL_MANPAGES was removed a long time ago. And do you also want to fix all ports that install man pages directly without providing the magic option MANPAGES? And then why not fix all other ports that don't install them even if they are present in the distribution file too? They are essential *documentation*. This would not be a waste of time... [1] I don't remember swearing allegiance to the Porter's Handb...Bible. ;-) [2] https://www.reddit.com/r/freebsd/comments/nc5c5v/whats_the_difference_between_docs_and_manpages/ On 17/08/24 11:07, Gleb Popov wrote: > On Sat, Aug 17, 2024 at 11:39 AM Nicola Vitale<nivit@freebsd.org> wrote: >> +%%PORTDOCS%%share/man/man1/kitty.1.gz >> +%%PORTDOCS%%share/man/man5/kitty.conf.5.gz > Note in "5.17.4. Install Additional Documentation" says [1] > >> The DOCS option only controls additional documentation installed in DOCSDIR. It does not apply to standard man pages and info pages. > So these files are better handled by the MANPAGES option. > > [1]https://docs.freebsd.org/en/books/porters-handbook/book/#install-documentation -- -- Nicola Vitale --------------5LHIk79tUfiAurjaWEGNB1UE Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit <!DOCTYPE html> <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body> <p>Hi,<br> </p> <p>thanks for the advice, but [1] the option MANPAGES is not present in the Porter's Handbook, and the section 5.12 (Man pages) says only that "manual pages must be placed in <span class="filename">pkg-plist along with the rest of the files". This distinction between man pages and other docs is misleading in my opinion. "What are docs?" [2]<br> </span></p> <p>Furthermore, x11/kitty is not the only one that uses %%PORTDOCS%%/share/man in pkg-plist, and NO_INSTALL_MANPAGES was removed a long time ago.</p> <p>And do you also want to fix all ports that install man pages directly without providing the magic option MANPAGES?</p> <p>And then why not fix all other ports that don't install them even if they are present in the distribution file too? They are essential *documentation*.<br> </p> <p>This would not be a waste of time...</p> <p>[1] I don't remember swearing allegiance to the Porter's Handb...Bible. ;-)</p> <p>[2] <a class="moz-txt-link-freetext" href="https://www.reddit.com/r/freebsd/comments/nc5c5v/whats_the_difference_between_docs_and_manpages/">https://www.reddit.com/r/freebsd/comments/nc5c5v/whats_the_difference_between_docs_and_manpages/</a><br>; </p> <p>On 17/08/24 11:07, Gleb Popov wrote:</p> <blockquote type="cite" cite="mid:CALH631kWKg1o8MmU=TZcPO7+5vOAAdOj1XpJSAyN1G-EEAKOPA@mail.gmail.com"> <pre class="moz-quote-pre" wrap="">On Sat, Aug 17, 2024 at 11:39 AM Nicola Vitale <a class="moz-txt-link-rfc2396E" href="mailto:nivit@freebsd.org"><nivit@freebsd.org></a> wrote: </pre> <blockquote type="cite"> <pre class="moz-quote-pre" wrap=""> +%%PORTDOCS%%share/man/man1/kitty.1.gz +%%PORTDOCS%%share/man/man5/kitty.conf.5.gz </pre> </blockquote> <pre class="moz-quote-pre" wrap=""> Note in "5.17.4. Install Additional Documentation" says [1] </pre> <blockquote type="cite"> <pre class="moz-quote-pre" wrap="">The DOCS option only controls additional documentation installed in DOCSDIR. It does not apply to standard man pages and info pages. </pre> </blockquote> <pre class="moz-quote-pre" wrap=""> So these files are better handled by the MANPAGES option. [1] <a class="moz-txt-link-freetext" href="https://docs.freebsd.org/en/books/porters-handbook/book/#install-documentation">https://docs.freebsd.org/en/books/porters-handbook/book/#install-documentation</a>; </pre> </blockquote> <pre class="moz-signature" cols="72">-- -- Nicola Vitale</pre> </body> </html> --------------5LHIk79tUfiAurjaWEGNB1UE--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7ad037a5-a92c-455e-b54c-9287e4fe5749>