Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 10 Feb 2011 17:39:30 +0100
From:      Koop Mast <kwm@rainbow-runner.nl>
To:        arrowdodger <6yearold@gmail.com>
Cc:        Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org>, freebsd-ports@freebsd.org
Subject:   Re: Request for new port review: TortoiseHG.
Message-ID:  <1297355970.22746.4.camel@headache.rainbow-runner.nl>
In-Reply-To: <AANLkTinGcPu9JPB8gThY7PYP52BR1rLE0k3izakERRsq@mail.gmail.com>
References:  <AANLkTin%2BCskJf8vP9iZwRvtC%2B66F%2BD6VPr6JbbO4v6pT@mail.gmail.com> <AANLkTimHUP5YvMrLuJ9NKET0=FyEO-M-5P8GJAJeU%2Bek@mail.gmail.com> <AANLkTi=uPh6PJiBcNWyMRnWK9Wf18R9eY91%2Be1CXRTgQ@mail.gmail.com> <AANLkTikwEoU=O5%2BncTPEOZMaMGFfoDLC_Q%2Bnr_NbWiec@mail.gmail.com> <AANLkTimx%2B6ybx9ULw8a=bfMZJ0tC1MKcg_QzRKsTTvjU@mail.gmail.com> <20110209161008.GD87684@bonjour.sunpoet.net> <AANLkTikH51z9OERxbqQsNHsWyBkuKR_e09geAkRWjwPx@mail.gmail.com> <20110210143506.GA66529@bonjour.sunpoet.net> <AANLkTinGcPu9JPB8gThY7PYP52BR1rLE0k3izakERRsq@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 2011-02-10 at 18:21 +0300, arrowdodger wrote:
> On Thu, Feb 10, 2011 at 5:35 PM, Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org
> > wrote:
> 
> > On Thu, Feb 10, 2011 at 04:36:40PM +0300, arrowdodger wrote:
> > > I've updated port. The only thing left - setting dependency on py-gobject
> > by
> > > USE_GNOME variable.
> > > But if i run pkg_info -f on installed port, i see:
> > >
> > > > Dependency: py26-gobject-2.26.0
> > > >         dependency origin: devel/py-gobject
> > > >
> > > So, maybe this dependency is implicit and i should not care?
> >
> > Obviously USE_GNOME does not support devel/py-gobject now. All you can
> > do is to use BUILD_DEPENDS/RUN_DEPENDS.

There is now a pygobject USE_GNOME switch.

-Koop

> > Your pkg_info result indicates that you've installed gobject, but it
> > means nothing to users of this port. The ports infrastructure generates
> > dependency list according to the Makefile. If py-gobject is required,
> > add it to the corresponding *_DEPENDS explicitly. Otherwise gobject will
> > not be installed.
> >
> > > Updated port can be obtained here:
> > > http://intara.org.ru/tortoisehg1.shar
> > > or from attachment.
> >
> > Some comments:
> > - PORTNAME can be different with the path. PORTNAME=tortoisehg is OK.
> > - We usually use "USE_PYTHON=yes"
> > - It would be better to keep patches in *-patch: targets.
> >  Move "${REINPLACE_CMD}" actions to post-patch:.
> > - If this port does not need to run configure or so. Use
> > do-configure:
> >        @${DO_NADA}
> >
> > Regards,
> >
> Done.
> 
> How should i submit new port? Open an PR?
> _______________________________________________
> freebsd-ports@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-ports
> To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org"





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1297355970.22746.4.camel>