Date: Sat, 20 Mar 2021 08:18:32 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Gleb Popov <arrowd@freebsd.org> Cc: ports-committers <ports-committers@freebsd.org>, svn-ports-all <svn-ports-all@freebsd.org>, svn-ports-head <svn-ports-head@freebsd.org> Subject: Re: svn commit: r568794 - in head/multimedia/pipewire: . files Message-ID: <20210320081832.GA21788@FreeBSD.org> In-Reply-To: <CALH631kuedo7Ch%2BOphQaGW_iru6UOWez7O5xkrZQ51a7Q073aw@mail.gmail.com> References: <202103191336.12JDaj8i012572@repo.freebsd.org> <20210319174447.GA16542@FreeBSD.org> <CALH631krOy0fzL_V4Sz58z4TCFvEfKvqfCYbWCe=XpkTC99b5Q@mail.gmail.com> <20210320033712.GA18472@FreeBSD.org> <CALH631kuedo7Ch%2BOphQaGW_iru6UOWez7O5xkrZQ51a7Q073aw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Mar 20, 2021 at 10:38:30AM +0300, Gleb Popov wrote: > On Sat, Mar 20, 2021 at 6:37 AM Alexey Dokuchaev <danfe@freebsd.org> wrote: > ... > > On Fri, Mar 19, 2021 at 10:16:35PM +0300, Gleb Popov wrote: > > > Exactly this. > > > > Understood. Please try to write more elaborate commit logs next time, > > so everyone could easily see what's going on, not just you or me. > > I clearly remember the case where you criticized a committer for a too > lengthy commit message. I'll try my best next time, anyways. That doesn't sound like me at all, I love elaborate commit messages (as long as they are of why-ish, not what-ish type and not merely translate the commit diff in English). I'll have to dig into my sent-mail to see what were the circumstances in that particular case. > P.S. With all these "do the repocopy!" and "bad commit message!" you're > really living up to your surname. No offence, just joking. I don't understand. There are certain bylaws and even rules of how we do things in the common repo, those practices are instated to make everyone's work easier. Waived repocopies and poor commit logs make this harder. And I'm not just complaining, I actually go and fix the mess when I see there's no interest from the original committer. Did I ever get a "thank you" back? No, I got "you're really living up to your surname" from you. We have mentoring process to teach those things to new developers. So if it happens, something went wrong and needs fixing. These are not the style and formatting bugs; by ignoring or tolerating them we'd be lowering our quality bar, and this deprives people from working on ports. It's very sad to hear when people say something like "I wanted to update/work/ improve on that port, but it's so messy, history does not explain much, so I walked away". ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210320081832.GA21788>