Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 24 Apr 2026 15:29:30 +0000
From:      John Baldwin <jhb@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Cc:        Alex Richardson <arichardson@FreeBSD.org>
Subject:   git: 9c4106c35059 - stable/15 - rtld: silence clang's unterminated-string-initialization warning
Message-ID:  <69eb8c5a.360f1.2b25d0ea@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch stable/15 has been updated by jhb:

URL: https://cgit.FreeBSD.org/src/commit/?id=9c4106c350592b59874e8612458871025020df8b

commit 9c4106c350592b59874e8612458871025020df8b
Author:     Alex Richardson <arichardson@FreeBSD.org>
AuthorDate: 2025-12-16 18:09:10 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2026-04-24 15:26:39 +0000

    rtld: silence clang's unterminated-string-initialization warning
    
    Since the initializer is used in other places where we can't just
    replace it with a char-by-char initializer, this adds a macro for the
    nonstring attribute (match the linuxkpi definition).
    
    Reviewed by:    emaste, jhb
    MFC after:      1 week
    Differential Revision: https://reviews.freebsd.org/D52535
    
    (cherry picked from commit 86f325711c07b723b85c031d581d0a5c1a0964f3)
---
 lib/libsysdecode/utrace.c      | 3 ++-
 libexec/rtld-elf/rtld.c        | 3 ++-
 libexec/rtld-elf/rtld_utrace.h | 2 +-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/lib/libsysdecode/utrace.c b/lib/libsysdecode/utrace.c
index 67ba86bfbf7b..8932f4b7e58f 100644
--- a/lib/libsysdecode/utrace.c
+++ b/lib/libsysdecode/utrace.c
@@ -169,7 +169,8 @@ sysdecode_utrace(FILE *fp, void *p, size_t len)
 	struct utrace_malloc um;
 	struct utrace_malloc32 *pm;
 #endif
-	static const char rtld_utrace_sig[RTLD_UTRACE_SIG_SZ] = RTLD_UTRACE_SIG;
+	static const char rtld_utrace_sig[RTLD_UTRACE_SIG_SZ] __nonstring =
+	    RTLD_UTRACE_SIG;
 
 	if (len == sizeof(struct utrace_rtld) && bcmp(p, rtld_utrace_sig,
 	    sizeof(rtld_utrace_sig)) == 0)
diff --git a/libexec/rtld-elf/rtld.c b/libexec/rtld-elf/rtld.c
index 8ae0685b02d9..29984e40b574 100644
--- a/libexec/rtld-elf/rtld.c
+++ b/libexec/rtld-elf/rtld.c
@@ -363,7 +363,8 @@ ld_utrace_log(int event, void *handle, void *mapbase, size_t mapsize,
     int refcnt, const char *name)
 {
 	struct utrace_rtld ut;
-	static const char rtld_utrace_sig[RTLD_UTRACE_SIG_SZ] = RTLD_UTRACE_SIG;
+	static const char rtld_utrace_sig[RTLD_UTRACE_SIG_SZ] __nonstring =
+	    RTLD_UTRACE_SIG;
 
 	memset(&ut, 0, sizeof(ut));	/* clear holes */
 	memcpy(ut.sig, rtld_utrace_sig, sizeof(ut.sig));
diff --git a/libexec/rtld-elf/rtld_utrace.h b/libexec/rtld-elf/rtld_utrace.h
index c14a62ddcb0b..dee807cc0098 100644
--- a/libexec/rtld-elf/rtld_utrace.h
+++ b/libexec/rtld-elf/rtld_utrace.h
@@ -49,7 +49,7 @@
 #define	RTLD_UTRACE_SIG			"RTLD"
 
 struct utrace_rtld {
-	char sig[RTLD_UTRACE_SIG_SZ];
+	char sig[RTLD_UTRACE_SIG_SZ] __nonstring;
 	int event;
 	void *handle;
 	void *mapbase;			/* Used for 'parent' and 'init/fini' */


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?69eb8c5a.360f1.2b25d0ea>