Date: Sat, 19 Oct 2013 18:09:42 +0200 From: Tijl Coosemans <tijl@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org>, Danilo Egea Gondolfo <danilo@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r330645 - head/audio/audacity Message-ID: <20131019180942.09929707@kalimero.tijl.coosemans.org> In-Reply-To: <20131019113111.GA78540@FreeBSD.org> References: <201310171430.r9HEUJZY033529@svn.freebsd.org> <20131017171050.2ce0ae53@kalimero.tijl.coosemans.org> <20131019113111.GA78540@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 19 Oct 2013 11:31:11 +0000 Alexey Dokuchaev wrote: > On Thu, Oct 17, 2013 at 05:10:50PM +0200, Tijl Coosemans wrote: >> On Thu, 17 Oct 2013 14:30:19 +0000 (UTC) Danilo Egea Gondolfo wrote: >>> Author: danilo >>> Date: Thu Oct 17 14:30:19 2013 >>> New Revision: 330645 >>> URL: http://svnweb.freebsd.org/changeset/ports/330645 >>> >>> Log: >>> - Disable SSE if the arch is powerpc [1] >>> >>> +.if ${ARCH} == "i386" || ${ARCH} == "powerpc" >>> +SSE_CFLAGS= -mno-sse -mno-sse2 >>> .endif >> >> If this is a problem on powerpc it's probably also a problem on arm, >> mips, and so on, so maybe it's better to test for ${ARCH} != "amd64" > > Wouldn't checking for MACHINE_CPU:Msse(2) suffice and make eveyone happy? > SSE are not -specific. I looked into why the port is trying to use SSE on PowerPC and it looks like there's a bug in the Makefile: SSE_CONFIGURE_WITH=sse should be SSE_CONFIGURE_ENABLE=sse. And "SSE" should be moved from OPTIONS_DEFAULT to OPTIONS_DEFAULT_amd64. Then you can remove SSE_CFLAGS everywhere. The question is if this should be an option at all. I think it's ok to just enable SSE on all CPUs that support it like this: .if ${MACHINE_CPU:Msse} CONFIGURE_ARGS+= --enable-sse .else CONFIGURE_ARGS+= --disable-sse .endif
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131019180942.09929707>