Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 29 Mar 2024 18:49:15 +0300
From:      Michael Zhilin <mizhka@gmail.com>
To:        Daniel Engberg <daniel.engberg.lists@pyret.net>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org,  dev-commits-ports-main@freebsd.org, lwhsu@freebsd.org
Subject:   Re: git: 9784fb237cdf - main - cad/libbgcode: new port
Message-ID:  <CAF19XB%2Bm8cd8nAqtBkZRrEf2rmv2Cm1yoOOyQOTFSjgmsp7m%2Bw@mail.gmail.com>
In-Reply-To: <9e4f95a9f17095b157b809e469495723@mail.infomaniak.com>
References:  <202403281937.42SJbYnV072687@gitrepo.freebsd.org> <9e4f95a9f17095b157b809e469495723@mail.infomaniak.com>

next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000b11e280614ce951f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Thank you, Daniel!
I'll try to follow the handbook as it's very cool.

Fixed.

Best regards,
  Michael

On Fri, Mar 29, 2024 at 12:36=E2=80=AFPM Daniel Engberg <
daniel.engberg.lists@pyret.net> wrote:

> On 2024-03-28T20:37:34.000+01:00, Michael Zhilin <mizhka@FreeBSD.org>
> wrote:
> >  The branch main has been updated by mizhka:
> >
> > URL:
> https://cgit.FreeBSD.org/ports/commit/?id=3D9784fb237cdf00b5f379c90df5c2d=
9f2bec97ea3
> >
> > commit 9784fb237cdf00b5f379c90df5c2d9f2bec97ea3
> > Author:     Michael Zhilin <mizhka@FreeBSD.org>
> > AuthorDate: 2024-03-06 19:53:23 +0000
> > Commit:     Michael Zhilin <mizhka@FreeBSD.org>
> > CommitDate: 2024-03-28 19:31:42 +0000
> >
> >     cad/libbgcode: new port
> >
> >     It is required by PrusaSlicer 2.7+. This port provides library and
> >     binary to work with g-code (read/write/convert)
> >
> >     Reported by: Teodor Sigaev <teodorsigaev@gmail.com>
> >     Reviewed by: lwhsu (mentor)
> >     Sponsored by: Postgres Professional
> >     Differential Revision: https://reviews.freebsd.org/D44257
> > ---
> >  cad/Makefile                                       |  1 +
> >  cad/libbgcode/Makefile                             | 27
> ++++++++++++++++++++++
> >  cad/libbgcode/distinfo                             |  5 ++++
> >  cad/libbgcode/files/patch-CMakeLists.txt           | 13 +++++++++++
> >  cad/libbgcode/files/patch-deps_CMakeLists.txt      | 23
> ++++++++++++++++++
> >  .../files/patch-deps_heatshrink_heatshrink.cmake   | 12 ++++++++++
> >  cad/libbgcode/pkg-descr                            |  2 ++
> >  cad/libbgcode/pkg-plist                            | 21
> +++++++++++++++++
> >  8 files changed, 104 insertions(+)
> >
> > diff --git a/cad/Makefile b/cad/Makefile
> > index e85ed462ada0..f43f0c101c4f 100644
> > --- a/cad/Makefile
> > +++ b/cad/Makefile
> > @@ -74,6 +74,7 @@
> >      SUBDIR +=3D ldview
> >      SUBDIR +=3D leocad
> >      SUBDIR +=3D lepton-eda
> > +    SUBDIR +=3D libbgcode
> >      SUBDIR +=3D libgdsii
> >      SUBDIR +=3D libopencad
> >      SUBDIR +=3D librecad
> > diff --git a/cad/libbgcode/Makefile b/cad/libbgcode/Makefile
> > new file mode 100644
> > index 000000000000..ffa5500927c5
> > --- /dev/null
> > +++ b/cad/libbgcode/Makefile
> > @@ -0,0 +1,27 @@
> > +PORTNAME=3D    libbgcode
> > +DISTVERSION=3D 0.2.0
> > +CATEGORIES=3D  cad
> > +
> > +MAINTAINER=3D  teodorsigaev@gmail.com
> > +COMMENT=3D     Prusa Block & Binary G-code reader/writer/converter
> > +WWW=3D         https://github.com/prusa3d/libbgcode
> > +
> > +LICENSE=3D     AGPLv3
> > +LICENSE_FILE=3D        ${WRKSRC}/LICENSE
> > +
> > +LIB_DEPENDS=3D libboost_nowide.so:devel/boost-libs
> > +
> > +USES=3D        cmake
> > +
> > +USE_GITHUB=3D  yes
> > +GH_ACCOUNT=3D  prusa3d
> > +GH_TAGNAME=3D  6f43cb004ef3d3bda37dde49f6235e24d2717629
> > +GH_TUPLE=3D    atomicobject:heatshrink:v0.4.1:heatshrink
> > +
> > +CMAKE_ARGS+=3D -DBUILD_SHARED_LIBS=3DON \
> > +             -DLibBGCode_BUILD_DEPS=3DON \
> > +             -DLibBGCode_BUILD_TESTS=3DOFF
> > +
> ...
>
> Hi,
>
> Please try to follow Poters Handbook,
> (GH_TAGNAME  should use short hash)
>
> https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_=
sites-github
>
> CMAKE_ARGS+=3D should be CMAKE_ARGS=3D and you can also use CMAKE_OFF and
> CMAKE_ON instead which probably is a bit cleaner.
> https://docs.freebsd.org/en/books/porters-handbook/book/#using-cmake
>
> Best regards,
> Daniel (diizzy@)
>

--000000000000b11e280614ce951f
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Thank you, Daniel!=C2=A0</div><div>I&#39;ll try to fo=
llow the handbook as it&#39;s very cool.<br></div><div><br></div><div>Fixed=
. <br></div><div><br></div><div>Best regards,</div><div>=C2=A0 Michael</div=
></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr"=
>On Fri, Mar 29, 2024 at 12:36=E2=80=AFPM Daniel Engberg &lt;<a href=3D"mai=
lto:daniel.engberg.lists@pyret.net">daniel.engberg.lists@pyret.net</a>&gt; =
wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0=
px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 2024-0=
3-28T20:37:34.000+01:00, Michael Zhilin &lt;mizhka@FreeBSD.org&gt; wrote:<b=
r>
&gt;=C2=A0 The branch main has been updated by mizhka:<br>
&gt; <br>
&gt; URL: <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3D9784fb237c=
df00b5f379c90df5c2d9f2bec97ea3" rel=3D"noreferrer" target=3D"_blank">https:=
//cgit.FreeBSD.org/ports/commit/?id=3D9784fb237cdf00b5f379c90df5c2d9f2bec97=
ea3</a><br>
&gt; <br>
&gt; commit 9784fb237cdf00b5f379c90df5c2d9f2bec97ea3<br>
&gt; Author:=C2=A0 =C2=A0 =C2=A0Michael Zhilin &lt;mizhka@FreeBSD.org&gt;<b=
r>
&gt; AuthorDate: 2024-03-06 19:53:23 +0000<br>
&gt; Commit:=C2=A0 =C2=A0 =C2=A0Michael Zhilin &lt;mizhka@FreeBSD.org&gt;<b=
r>
&gt; CommitDate: 2024-03-28 19:31:42 +0000<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0cad/libbgcode: new port<br>
&gt;=C2=A0 =C2=A0 =C2=A0<br>
&gt;=C2=A0 =C2=A0 =C2=A0It is required by PrusaSlicer 2.7+. This port provi=
des library and<br>
&gt;=C2=A0 =C2=A0 =C2=A0binary to work with g-code (read/write/convert)<br>
&gt;=C2=A0 =C2=A0 =C2=A0<br>
&gt;=C2=A0 =C2=A0 =C2=A0Reported by: Teodor Sigaev &lt;<a href=3D"mailto:te=
odorsigaev@gmail.com" target=3D"_blank">teodorsigaev@gmail.com</a>&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0Reviewed by: lwhsu (mentor)<br>
&gt;=C2=A0 =C2=A0 =C2=A0Sponsored by: Postgres Professional<br>
&gt;=C2=A0 =C2=A0 =C2=A0Differential Revision: <a href=3D"https://reviews.f=
reebsd.org/D44257" rel=3D"noreferrer" target=3D"_blank">https://reviews.fre=
ebsd.org/D44257</a><br>
&gt; ---<br>
&gt;=C2=A0 cad/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0|=C2=A0 1 +<br>
&gt;=C2=A0 cad/libbgcode/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 27 ++++++++=
++++++++++++++<br>
&gt;=C2=A0 cad/libbgcode/distinfo=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 5 +++=
+<br>
&gt;=C2=A0 cad/libbgcode/files/patch-CMakeLists.txt=C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0| 13 +++++++++++<br>
&gt;=C2=A0 cad/libbgcode/files/patch-deps_CMakeLists.txt=C2=A0 =C2=A0 =C2=
=A0 | 23 ++++++++++++++++++<br>
&gt;=C2=A0 .../files/patch-deps_heatshrink_heatshrink.cmake=C2=A0 =C2=A0| 1=
2 ++++++++++<br>
&gt;=C2=A0 cad/libbgcode/pkg-descr=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 2 ++<br>
&gt;=C2=A0 cad/libbgcode/pkg-plist=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 21 +++++++++++++=
++++<br>
&gt;=C2=A0 8 files changed, 104 insertions(+)<br>
&gt; <br>
&gt; diff --git a/cad/Makefile b/cad/Makefile<br>
&gt; index e85ed462ada0..f43f0c101c4f 100644<br>
&gt; --- a/cad/Makefile<br>
&gt; +++ b/cad/Makefile<br>
&gt; @@ -74,6 +74,7 @@<br>
&gt;=C2=A0 =C2=A0 =C2=A0 SUBDIR +=3D ldview<br>
&gt;=C2=A0 =C2=A0 =C2=A0 SUBDIR +=3D leocad<br>
&gt;=C2=A0 =C2=A0 =C2=A0 SUBDIR +=3D lepton-eda<br>
&gt; +=C2=A0 =C2=A0 SUBDIR +=3D libbgcode<br>
&gt;=C2=A0 =C2=A0 =C2=A0 SUBDIR +=3D libgdsii<br>
&gt;=C2=A0 =C2=A0 =C2=A0 SUBDIR +=3D libopencad<br>
&gt;=C2=A0 =C2=A0 =C2=A0 SUBDIR +=3D librecad<br>
&gt; diff --git a/cad/libbgcode/Makefile b/cad/libbgcode/Makefile<br>
&gt; new file mode 100644<br>
&gt; index 000000000000..ffa5500927c5<br>
&gt; --- /dev/null<br>
&gt; +++ b/cad/libbgcode/Makefile<br>
&gt; @@ -0,0 +1,27 @@<br>
&gt; +PORTNAME=3D=C2=A0 =C2=A0 libbgcode<br>
&gt; +DISTVERSION=3D 0.2.0<br>
&gt; +CATEGORIES=3D=C2=A0 cad<br>
&gt; +<br>
&gt; +MAINTAINER=3D=C2=A0 <a href=3D"mailto:teodorsigaev@gmail.com" target=
=3D"_blank">teodorsigaev@gmail.com</a><br>
&gt; +COMMENT=3D=C2=A0 =C2=A0 =C2=A0Prusa Block &amp; Binary G-code reader/=
writer/converter<br>
&gt; +WWW=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<a href=3D"https://github.com=
/prusa3d/libbgcode" rel=3D"noreferrer" target=3D"_blank">https://github.com=
/prusa3d/libbgcode</a><br>
&gt; +<br>
&gt; +LICENSE=3D=C2=A0 =C2=A0 =C2=A0AGPLv3<br>
&gt; +LICENSE_FILE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 ${WRKSRC}/LICENSE<br>
&gt; +<br>
&gt; +LIB_DEPENDS=3D libboost_nowide.so:devel/boost-libs<br>
&gt; +<br>
&gt; +USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 cmake<br>
&gt; +<br>
&gt; +USE_GITHUB=3D=C2=A0 yes<br>
&gt; +GH_ACCOUNT=3D=C2=A0 prusa3d<br>
&gt; +GH_TAGNAME=3D=C2=A0 6f43cb004ef3d3bda37dde49f6235e24d2717629<br>
&gt; +GH_TUPLE=3D=C2=A0 =C2=A0 atomicobject:heatshrink:v0.4.1:heatshrink<br=
>
&gt; +<br>
&gt; +CMAKE_ARGS+=3D -DBUILD_SHARED_LIBS=3DON \<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-DLibBGCode_BUILD_DEP=
S=3DON \<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-DLibBGCode_BUILD_TES=
TS=3DOFF<br>
&gt; +<br>
...<br>
<br>
Hi,<br>
<br>
Please try to follow Poters Handbook,<br>
(GH_TAGNAME=C2=A0 should use short hash)<br>
<a href=3D"https://docs.freebsd.org/en/books/porters-handbook/book/#makefil=
e-master_sites-github" rel=3D"noreferrer" target=3D"_blank">https://docs.fr=
eebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github</a><=
br>
<br>
CMAKE_ARGS+=3D should be CMAKE_ARGS=3D and you can also use CMAKE_OFF and C=
MAKE_ON instead which probably is a bit cleaner.<br>
<a href=3D"https://docs.freebsd.org/en/books/porters-handbook/book/#using-c=
make" rel=3D"noreferrer" target=3D"_blank">https://docs.freebsd.org/en/book=
s/porters-handbook/book/#using-cmake</a><br>
<br>
Best regards,<br>
Daniel (diizzy@)<br>
</blockquote></div>

--000000000000b11e280614ce951f--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF19XB%2Bm8cd8nAqtBkZRrEf2rmv2Cm1yoOOyQOTFSjgmsp7m%2Bw>