Date: Fri, 13 Jun 2014 10:57:22 -0600 From: Warner Losh <imp@bsdimp.com> To: Glen Barber <gjb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Julio Merino <jmmv@freebsd.org>, src-committers@freebsd.org, Nathan Whitehorn <nwhitehorn@freebsd.org> Subject: Re: svn commit: r267332 - head/release Message-ID: <1EB9FE57-8231-439D-8E91-08452AAB2587@bsdimp.com> In-Reply-To: <20140613164934.GU1248@hub.FreeBSD.org> References: <201406101705.s5AH5gt8007603@svn.freebsd.org> <53973EC7.10306@freebsd.org> <D82BB88B-DE3E-4DE0-9935-C2ABDA382784@gmail.com> <20140613164934.GU1248@hub.FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Jun 13, 2014, at 10:49 AM, Glen Barber <gjb@freebsd.org> wrote: > On Fri, Jun 13, 2014 at 10:34:50AM -0600, Warner Losh wrote: >> >> On Jun 10, 2014, at 11:22 AM, Nathan Whitehorn <nwhitehorn@freebsd.org> wrote: >> >>> On 06/10/14 10:05, Julio Merino wrote: >>>> Author: jmmv >>>> Date: Tue Jun 10 17:05:41 2014 >>>> New Revision: 267332 >>>> URL: http://svnweb.freebsd.org/changeset/base/267332 >>>> >>>> Log: >>>> Strip out the test suite from the installation media. >>>> This affects the disc1.iso, dvd1.iso and bootonly.iso files. >>>> Obtained from: gjb >>>> >>>> Modified: >>>> head/release/Makefile >>>> >>>> Modified: head/release/Makefile >>>> ============================================================================== >>>> --- head/release/Makefile Tue Jun 10 17:04:30 2014 (r267331) >>>> +++ head/release/Makefile Tue Jun 10 17:05:41 2014 (r267332) >>>> @@ -155,7 +155,7 @@ system: packagesystem >>>> mkdir -p release >>>> cd ${WORLDDIR} && ${IMAKE} installkernel installworld distribution \ >>>> DESTDIR=${.OBJDIR}/release WITHOUT_RESCUE=1 WITHOUT_KERNEL_SYMBOLS=1 \ >>>> - WITHOUT_PROFILE=1 WITHOUT_SENDMAIL=1 WITHOUT_ATF=1 WITHOUT_LIB32=1 >>>> + WITHOUT_PROFILE=1 WITHOUT_SENDMAIL=1 MK_TESTS=no WITHOUT_LIB32=1 >>>> # Copy distfiles >>> >>> Shouldn't this be "WITHOUT_TESTS" or the like? I thought we weren't supposed to set MK_* at the command line. >> >> We recently started allowing MK_TESTS=no on the command line. In general, all of those WITHOUT_xxx should become MK_xxx=no in release/Makefile. Having the MK_xxxx version isolates us further from (a) the current defaults and (b) config files that turn it to the other direction. >> > > The WITH*_FOO -> MK_FOO change is on my TODO this weekend. I want to > run at least one full build before committing it. There’s no rush. What’s there now works, except in extreme circumstances. Testing of this stuff is good. It is way too easy to think a change is a NOP when in fact it breaks something subtle... Warner [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJTmy1yAAoJEGwc0Sh9sBEAqtwP/RYYWS6PSFVJDDTRKAK90sI6 f9LOaAnEedHslzuqF6zWdWFCblmI1zLWijQVAOpUXUriECHRZyD77dNtm6Q2qy60 8GSL6EUZziWSLVWgf7FvTzW3EoGcHctSzCT7xvk+GYHi8GPHaJWrFyYAo7fSTkOG SLk77UUwbfi2vmpO3u2s6P0mSJwurAnhvJU9zbxliQx3u1h1/EQqwFjnn+IM9rHH oPEaJ/yYGS8IE/d+PVfi51kp7ycMtQdVwt5OM75uz4l0+p72+BadXeZnhEUdkACU y56e1tebkofwhmpij1heTsxucqNkL7BsSOeHp0IC+BZwdmG/vtrbSo/UeR3X3uVv 1QohlmDN9fVKnX3nz9Y08w1ovB0LeFKA2V7rhfnYbW4U0hJEk+sp982teR9y8GkN huzzniM+eF9RQBGzT+AUdiJPPnsWw1GqxJIVDlfc4fZwCmuaCaR6rtrGxDqwmuhK x2ftA43iMub4lVEXSYRr6xISrWg7U9xhyl1gk567EBL/ZlOO0NgbloYiLQNhHV37 Zes/zK5q2vaKHdkqSiA0MpM0YzjojZU9AVP6wiIDlo31sxb/Xc6o287Kk2XtJJXQ u96EEd9on3Nk0x8Qqa3sgT/iNtXKLMH56PM0mgVWLPzc4AM5O0s0iqPlihoBe5SF zyh+xAH2kaUh7eOsrRcz =7Z/R -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1EB9FE57-8231-439D-8E91-08452AAB2587>