Date: Tue, 3 Oct 2000 19:42:55 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: Bill Fumerola <billf@chimesnet.com> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_fw.c Message-ID: <20001003194255.D63113@sunbay.com> In-Reply-To: <20001003124011.T38472@jade.chc-chimes.com>; from billf@chimesnet.com on Tue, Oct 03, 2000 at 12:40:11PM -0400 References: <200010031218.FAA51112@freefall.freebsd.org> <20001003124011.T38472@jade.chc-chimes.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Oct 03, 2000 at 12:40:11PM -0400, Bill Fumerola wrote: > On Tue, Oct 03, 2000 at 05:18:11AM -0700, Ruslan Ermilov wrote: > > > Modified files: > > sys/netinet ip_fw.c > > Log: > > Added the missing ntohs() conversion when matching IP packet with > > the IP_FW_IF_IPID rule. (We have recently decided to keep the > > ip_id field in network byte order inside the kernel, see revision > > 1.140 of src/sys/netinet/ip_input.c). > > Crappy. I haven't been following -current as closely as possible. > This is also true for 4.1.1. > > I did not like to have the conversion happen in userland, and I > > think that the similar conversions for fw_tcp(seq|ack|win) should > > be moved out of userland (src/sbin/ipfw/ipfw.c) into the kernel. > > That's fine, I was just trying to save CPU (perhaps needlessly) by > doing the conversion when we store it as opposed to when we check it. > To save CPU cycles, the conversion could be done in the kernel, when we handle IP_FW_ADD. -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001003194255.D63113>