Date: Wed, 28 Apr 2004 10:37:10 +0300 From: Ruslan Ermilov <ru@freebsd.org> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/boot/i386/boot0 Makefile boot0.s boot0_512.s boot0sio.s Message-ID: <20040428073710.GD25064@ip.net.ua> In-Reply-To: <20040428144757.T4950@gamplex.bde.org> References: <200404271907.i3RJ7ZkI028848@repoman.freebsd.org> <20040427192403.GC75827@ip.net.ua> <20040428144757.T4950@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--mSxgbZZZvrAyzONB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 28, 2004 at 02:52:39PM +1000, Bruce Evans wrote: > On Tue, 27 Apr 2004, Ruslan Ermilov wrote: >=20 > > On Tue, Apr 27, 2004 at 12:07:35PM -0700, Poul-Henning Kamp wrote: > > > phk 2004/04/27 12:07:35 PDT > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/boot/i386/boot0 Makefile > > > Added files: > > > sys/boot/i386/boot0 boot0_512.s > > > Removed files: > > > sys/boot/i386/boot0 boot0.s boot0sio.s > > > Log: > > > Change from '#' to "//" comment character to allow CPP preprocessin= g. > > > > > This is backwards, please fix. Also, the preprocessed files >=20 > So "# foo" is a valid comment and not a preprocessor directive in *.S > provided "foo" is not a standard preprocessor directive? >=20 Hmm, no it's not. I will fix all .S files under sys/boot/ to use a proper syntax for single-line comments (`//'). Only lines that _start_ with `#' need to be fixed. My main point still applies: adding a special CPP preprocessing to this makefile was backwards, having the .S file is enough, though I confirm that I was confused about single-line comments in the mixed (assmebler + CPP) input. Reading the cpp.info now revealed the truth. Nevertheless, I've ordered a repo-copy of boot0sio.s to boot0.S. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --mSxgbZZZvrAyzONB Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAj18mUkv4P6juNwoRAg6LAKCLYvVTD7+V2pHPQYp5SkQc0kDkHgCfeBjN D8uaNSnu3Ar3qGCYj2IyDu0= =OEac -----END PGP SIGNATURE----- --mSxgbZZZvrAyzONB--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040428073710.GD25064>