Date: Sat, 26 Apr 2025 19:19:03 +0300 From: Vladimir Kondratyev <wulf@FreeBSD.org> To: freebsd-current@freebsd.org Subject: Re: April 2025 stabilization week Message-ID: <7c4e115c-f0a5-4462-a34f-38291770aa92@FreeBSD.org> In-Reply-To: <aAqHHxkNWEYewbL2@cell.glebi.us> References: <aAX7DZ-zFkOyOhij@cell.glebi.us> <CANCZdfoRA-q_CVkBAxYwQH%2BrDq1T%2Be3=4xQpF=UgSYMr7KZA3w@mail.gmail.com> <447332f8-a8bc-4b90-a605-4c705a58f491@app.fastmail.com> <aAp1aOeUWFL7ukMQ@cell.glebi.us> <4aad4a70-a953-458b-ac37-675b6901f28c@app.fastmail.com> <aAqHHxkNWEYewbL2@cell.glebi.us>
index | next in thread | previous in thread | raw e-mail
On 4/24/25 21:46, Gleb Smirnoff wrote: > On Thu, Apr 24, 2025 at 05:48:46PM +0000, Dave Cottlehuber wrote: > D> On Thu, 24 Apr 2025, at 17:31, Gleb Smirnoff wrote: > D> > D> This issue actually came up last month but I had no time to > D> > investigate > D> > D> then, details > D> > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=286045 > D> > > D> > Is this regression since last stabweek or from an earlier point? > D> > D> Just since March stabweek. > > There were no changes to the driver :( > > Any chance you can make a bisect? > I think it is regression from daa098cc37b9 Test this patch: diff --git a/sys/dev/iicbus/iichid.c b/sys/dev/iicbus/iichid.c index eeabf817616..d82beb52d58 100644 --- a/sys/dev/iicbus/iichid.c +++ b/sys/dev/iicbus/iichid.c @@ -630,7 +630,7 @@ iichid_intr(void *context) error = iichid_cmd_read(sc, sc->intr_buf, sc->intr_bufsize, &actual); THREAD_NO_SLEEPING(); if (error == 0) { - if (sc->power_on) { + if (sc->power_on && sc->open) { if (actual != 0) sc->intr_handler(sc->intr_ctx, sc->intr_buf, actual); -- WBR Vladimir Kondratyevhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7c4e115c-f0a5-4462-a34f-38291770aa92>