Date: Thu, 22 May 2014 13:29:47 -0400 From: Allan Jude <allanjude@freebsd.org> To: Steven Hartland <killing@multiplay.co.uk>, Warren Block <wblock@wonkity.com> Cc: freebsd-fs@freebsd.org, Benedict Reuschling <bcr@freebsd.org>, Eitan Adler <eadler@freebsd.org> Subject: Re: [patch] zfs sysctl patch Message-ID: <537E340B.5040108@freebsd.org> In-Reply-To: <7B840D2D10124A4FAC40C69E91E6C20D@multiplay.co.uk> References: <537D7431.4070103@freebsd.org> <alpine.BSF.2.00.1405212222170.28790@wonkity.com> <7B840D2D10124A4FAC40C69E91E6C20D@multiplay.co.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 2014-05-22 00:56, Steven Hartland wrote: > ----- Original Message ----- From: "Warren Block" <wblock@wonkity.com> > To: "Allan Jude" <allanjude@freebsd.org> > Cc: <freebsd-fs@freebsd.org>; "Benedict Reuschling" <bcr@freebsd.org>; > "Eitan Adler" <eadler@freebsd.org> > Sent: Thursday, May 22, 2014 5:25 AM > Subject: Re: [patch] zfs sysctl patch > > >> On Wed, 21 May 2014, Allan Jude wrote: >> >>> A recent commit (r266497 by smh) added a number of new sysctls for ZFS >>> >>> Two of these had minor typos, and the phrasing of another was very >>> awkward. >>> >>> --------------- >>> >>> Improve sysctl descriptions for: >>> vfs.zfs.dirty_data_max >>> vfs.zfs.dirty_data_max_max >>> vfs.zfs.dirty_data_sync >> >> Nice. Approved for the doc side, but please also get approval from smh. > > All good for me, thanks for reviewing and picking these up. > > Regards > Steve Did the name of the sysctl vfs.zfs.dirty_data_max_max come from OpenZFS or did we pick that? If it is ours, I would suggest changing it to dirty_data_max_limit because '*_max_max' is confusing and a bit misleading. -- Allan Jude [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTfjQOAAoJEJrBFpNRJZKfeoEP/2AiLRBHBNXlujkcwey34hWu 3XZFES5dd9rBkzwhBYLxJcwZ1XUyYPVSraBPXZCDlnsF8jKd3s68MBEER0YAj/9K PaFKXRPYWqcRqUjh21PGBhyNp0+2+FLoP/XNestc/FFYqv5umbHaqnw4kfojWaoF ZFffYyxwNyMkdv6evN1Fxr3KXZzBXY7hMDsdi3aLJ3lRgGF/50rQNEkMSHPBNlDE SJxG+28D2iACED1RsNiws9DdGMk2gUac1MNFZ3HIiIG7XuNZbt32rCHyFg3FgPJX KE2Tx4cWBtNMa0eolz1Fv8ipewAH+HBHId5pd4gJRO0oMluCdomCxC87QGn+yoka qAs4n9xHrRm34Bee/T4BWQR1HOGidb/lEmhE1Om0ZWDtCDSTTcXCJZHSf75+7CDj 04O5Cr7lPw/8yFcV3ThVqNT+htPPk7W0xbREjHCO2AoK919LK3HruibF+M/10NzI GNrFU4Boc2pTcLV74L6MtW0Ntc9+FCAeK6LC6tVEjK/oRN1WrPDqq5GL3SknKnbY 8sdHB7wvAThw8P4rMqAxUiInuBiyhPTXTiDB1osnG2t6EU7m7LE2Q7VY/05XWkk1 mrSQEgFNbirOv//CRjzbFGwpe+ZKerC28cWkp1CaThE72Q14ILIC647xRBMyuT5L jPxsJ3fVK40UP+xb6rDU =hYK+ -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?537E340B.5040108>