Date: Thu, 13 Apr 2023 21:39:29 -0700 From: Mark Millard <marklmi@yahoo.com> To: Charlie Li <vishwin@freebsd.org> Cc: Pawel Jakub Dawidek <pjd@FreeBSD.org>, Cy Schubert <Cy.Schubert@cschubert.com>, Mateusz Guzik <mjguzik@gmail.com>, dev-commits-src-main@freebsd.org, Current FreeBSD <freebsd-current@freebsd.org> Subject: Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75 Message-ID: <99382FF7-765C-455F-A082-C47DB4D5E2C1@yahoo.com> In-Reply-To: <5ce72375-90db-6d30-9f3b-a741c320b1bf@freebsd.org> References: <20230413071032.18BFF31F@slippy.cwsent.com> <D0D9BD06-C321-454C-A038-C55C63E0DD6B@dawidek.net> <20230413063321.60344b1f@cschubert.com> <CAGudoHG3rCx93gyJTmzTBnSe4fQ9=m4mBESWbKVWtAGRxen_4w@mail.gmail.com> <20230413135635.6B62F354@slippy.cwsent.com> <c41f9ed6-e557-9255-5a46-1a22d4b32d66@dawidek.net> <319a267e-3f76-3647-954a-02178c260cea@dawidek.net> <b60807e9-f393-6e6d-3336-042652ddd03c@freebsd.org> <441db213-2abb-b37e-e5b3-481ed3e00f96@dawidek.net> <5ce72375-90db-6d30-9f3b-a741c320b1bf@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Apr 13, 2023, at 21:27, Charlie Li <vishwin@freebsd.org> wrote: >=20 > Pawel Jakub Dawidek wrote: >> On 4/14/23 09:23, Charlie Li wrote: >>> Pawel Jakub Dawidek wrote: >>>> Here is the change that reverts most of the modifications and = disables cloning new blocks. It does retain ability to free existing = cloned blocks and keeps block_cloning feature around, so upgraded pools = can be imported and existing cloned blocks freed. >>>>=20 >>>> It does not handle replaying ZIL with block-cloning logs, so make = sure you import pools that were cleanly exported. >>>>=20 >>>> I'd appreciate if someone who can reproduce those corruptions could = try it. >>>>=20 >>>> = https://github.com/pjd/openzfs/commit/f2cfbcf76a733c44e25cba8c649162ef6804= 7103 >>>>=20 >>> Does not apply to sys/contrib/openzfs tip, conflicts in = module/os/freebsd/zfs/zfs_vnops_os.c and module/zfs/dmu.c. >> This should work: >> https://people.freebsd.org/~pjd/patches/brt_revert.patch > This results in missing files rather than corruption. FYI: in my original report for a context that has never had block_cloning enabled, I reported BOTH missing files and file content corruption in the poudriere-devel bulk build testing. This predates: https://people.freebsd.org/~pjd/patches/brt_revert.patch but had the changes from: https://github.com/openzfs/zfs/pull/14739/files The files were missing from packages installed to be used during a port's build. No other types of examples of missing files happened. (But only 11 ports failed.) =3D=3D=3D Mark Millard marklmi at yahoo.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?99382FF7-765C-455F-A082-C47DB4D5E2C1>