Date: Sun, 3 Jul 2011 15:35:50 +0100 From: Chris Rees <crees@freebsd.org> To: Alex Samorukov <samm@os2.kiev.ua> Cc: cvs-ports@freebsd.org, ports-committers@freebsd.org, Doug Barton <dougb@freebsd.org>, cvs-all@freebsd.org, Martin Wilke <miwi@freebsd.org> Subject: Re: cvs commit: ports/sysutils/atop Makefile distinfo ports/sysutils/atop/files atop.in pkg-message.in Message-ID: <CADLo83-6dUpPXQB8eDQcGUpzbR16a_hcvQ8fB_t-qeLAWTqeTQ@mail.gmail.com> In-Reply-To: <4E105B9B.4060602@os2.kiev.ua> References: <201107021323.p62DNWeP082020@repoman.freebsd.org> <4E0FB8DF.90904@FreeBSD.org> <4E105B9B.4060602@os2.kiev.ua>
index | next in thread | previous in thread | raw e-mail
On 3 July 2011 13:07, Alex Samorukov <samm@os2.kiev.ua> wrote: > Hello, > > Thank you for comments. > > On 07/03/2011 02:33 AM, Doug Barton wrote: >> >> Overall this looks good, just 2 small comments. It's not clear why it >> uses: >> >> # REQUIRE: DAEMON >> # BEFORE: LOGIN >> >> Instead of just >> >> # REQUIRE: LOGIN >> >> like most ports scripts do. > > Probably my copypaste from some other script. Better to replace with > REQUIRE: LOGIN. > >> Also the default empty assignment for _flags is neither necessary or >> desirable. > > Agree. Do i need to submit PR to fix this or you can do it without it? PR is probably best so it doesn't get lost in the mailing list. Chrishome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo83-6dUpPXQB8eDQcGUpzbR16a_hcvQ8fB_t-qeLAWTqeTQ>