Date: Tue, 05 Oct 2004 14:31:26 -0700 From: Nate Lawson <nate@root.org> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/acpi/acpidump acpi.c acpidump.c acpidump.h Message-ID: <416312AE.9050308@root.org> In-Reply-To: <4162E53A.40100@root.org> References: <200410050237.LAA20152@axe-inc.co.jp> <4162DEF0.1020809@root.org> <200410051409.30619.jhb@FreeBSD.org> <4162E53A.40100@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Nate Lawson wrote: > John Baldwin wrote: >> I agree. It makes the user's lives a lot easier if they procedure >> remains: >> >> - acpidump > foo.asl >> - hack on foo.asl to fix it >> - compile foo.asl to foo.dsdt >> - load foo.dsdt in the loader >> >> and have it all just work. Actually, you know, we could make this >> work on our own without requiring ACPI-CA to change. You just need to >> hack AcpiOsTableOverride() in OsdTable.c to return a pointer to an >> empty table for "SSDT" tables when the DSDT is overridden. In fact, I >> think that is probably where this behavior decision really belongs. > > Good idea, I'll look into this. If feasible, I'll commit this and > revert the acpidump change. Ok, I've committed a tested version with this approach. The only annoying part is that setting NewTable to NULL means "don't override this one" so I had to supply an empty no-op table in place of the SSDT. I backed out the acpidump changes. It would be better if ACPI-CA had an option where returning AE_NO_TABLES or something would mean "ignore this table completely". Right now, you can only override or leave the default table. -- Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?416312AE.9050308>