Date: Sun, 03 Oct 2004 16:55:14 -0700 From: Julian Elischer <julian@elischer.org> To: Stephan Uphoff <ups@tree.com> Cc: "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org> Subject: Re: scheduler (sched_4bsd) questions Message-ID: <41609162.9090502@elischer.org> In-Reply-To: <1096843419.38592.76.camel@palm.tree.com> References: <1096489576.3733.1868.camel@palm.tree.com> <200409291652.29990.jhb@FreeBSD.org> <1096496057.3733.2163.camel@palm.tree.com> <1096603981.21577.195.camel@palm.tree.com> <1096608201.21577.203.camel@palm.tree.com> <20041001141040.GA1556@peter.osted.lan> <1096647194.27811.12.camel@palm.tree.com> <20041001192551.GA3381@peter.osted.lan> <20041002053351.GA6259@peter.osted.lan> <415EEFFE.5080309@elischer.org> <20041002183120.GA1202@peter.osted.lan> <1096760257.34527.14.camel@palm.tree.com> <415FA496.6000902@elischer.org> <1096828937.38592.52.camel@palm.tree.com> <41607192.8020809@elischer.org> <1096843419.38592.76.camel@palm.tree.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Stephan Uphoff wrote:
> On Sun, 2004-10-03 at 17:39, Julian Elischer wrote:
>
>>Stephan Uphoff wrote:
>> you didn't answer this question..
>>
>>
>>>
>>>>Where is the critical_enter that matches the extra critical_exit()
>>>>you put in sched_switch()? I haven' been able to yet figure out how
>>>>you don't get a double exit. but I've only looked for a few minutes.
>>>
>>==== //depot/projects/nsched/sys/kern/sched_4bsd.c#58 -
>>/home/julian/p4/nsched/sys/kern/sched_4bsd.c ====
>>@@ -844,6 +844,8 @@
>> if (newtd == NULL || newtd->td_ksegrp != td->td_ksegrp)
>> slot_fill(td->td_ksegrp);
>> }
>>+ critical_exit();
>>+ td->td_pflags &= ~TDP_OWEPREEMPT;
>> }
>> if (newtd) {
>> /*
>>
>>
>>where is the matching critical_enter()?
interesting.. somehow when I applied that diff, the critical_enter disappeared?
>>
>
>
>>From Peter's unified diff:
>
> RCS file: /home/ncvs/src/sys/kern/sched_4bsd.c,v
> retrieving revision 1.65
> diff -u -r1.65 sched_4bsd.c
> --- sys/kern/sched_4bsd.c 16 Sep 2004 07:12:59 -0000 1.65
> +++ sys/kern/sched_4bsd.c 2 Oct 2004 14:46:29 -0000
> @@ -823,6 +823,7 @@
> TD_SET_CAN_RUN(td);
> else {
> td->td_ksegrp->kg_avail_opennings++;
> + critical_enter();
> if (TD_IS_RUNNING(td)) {
> /* Put us back on the run queue (kse and all).
> */
> setrunqueue(td, SRQ_OURSELF|SRQ_YIELDING);
> @@ -834,6 +835,8 @@
> */
> slot_fill(td->td_ksegrp);
> }
> + critical_exit();
> + td->td_pflags &= ~TDP_OWEPREEMPT;
> }
> if (newtd == NULL)
> newtd = choosethread();
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41609162.9090502>