Date: Tue, 5 Feb 2002 07:59:35 -0500 (EST) From: Lowell@world.std.com To: FreeBSD-gnats-submit@freebsd.org Subject: kern/34637: LINT is wrong -- NMBCLUSTERS doesn't auto-size if 0 Message-ID: <200202051259.g15CxZS06254@be-well.ilk.org>
next in thread | raw e-mail | index | archive | help
>Number: 34637 >Category: kern >Synopsis: LINT is wrong -- NMBCLUSTERS doesn't auto-size if 0 >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: doc-bug >Submitter-Id: current-users >Arrival-Date: Tue Feb 05 05:00:01 PST 2002 >Closed-Date: >Last-Modified: >Originator: Lowell Gilbert >Release: FreeBSD 4.5-STABLE i386 >Organization: >Environment: System: FreeBSD lowellg.ne.mediaone.net 4.5-STABLE FreeBSD 4.5-STABLE #0: Tue Feb 5 02:06:02 EST 2002 root@lowellg.ne.mediaone.net:/usr/obj/usr/src/sys/BE-WELL i386 >Description: LINT says that NMBCLUSTERS will autosize if set to zero. It doesn't; it only autosizes if not defined. >How-To-Repeat: [see LINT, compare to /sys/kern/uipc_mbuf.c] >Fix: [including a typo repair...] *** LINT~ Tue Feb 5 07:40:44 2002 --- LINT Tue Feb 5 07:41:07 2002 *************** *** 2376,2382 **** # Set the size of the mbuf KVM reservation, in clusters. This is scaled # by approximately 2048 bytes. The system will auto-size the mbuf area ! # if this options is not specified or set to 0. # options NMBCLUSTERS=1024 --- 2376,2382 ---- # Set the size of the mbuf KVM reservation, in clusters. This is scaled # by approximately 2048 bytes. The system will auto-size the mbuf area ! # if this option is not specified. # options NMBCLUSTERS=1024 Another alternative would be to change /sys/kern/uipc_mbuf.c so that it uses "#if !NMBCLUSTERS" instead of "#ifndef NMBCLUSTERS", but I think the code is fine, and changing LINT to reflect it is the better way to go. >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200202051259.g15CxZS06254>