Date: Mon, 26 Jan 2026 00:52:37 +0000 From: Mark Johnston <markj@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: 0e2e58806bc3 - stable/15 - arm64/vgic_v3: Fix an inverted test when reading GICD_I<C|S>ENABLER Message-ID: <6976bad5.8826.652d931e@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch stable/15 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=0e2e58806bc3a9e58a32e9e00aa1b38f31393f3f commit 0e2e58806bc3a9e58a32e9e00aa1b38f31393f3f Author: Mark Johnston <markj@FreeBSD.org> AuthorDate: 2026-01-15 14:04:06 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2026-01-26 00:51:44 +0000 arm64/vgic_v3: Fix an inverted test when reading GICD_I<C|S>ENABLER On read, these registers' fields return 1 if forwarding of the corresponding interrupt is enabled, and 0 otherwise. The test in read_enabler() was inverted. Reported by: Kevin Day <kevin@your.org> Reviewed by: andrew MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D54678 (cherry picked from commit 6fef0c9ee64cea1f22b6a33a0c4dd39f605b7465) --- sys/arm64/vmm/io/vgic_v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/arm64/vmm/io/vgic_v3.c b/sys/arm64/vmm/io/vgic_v3.c index 023406c64182..6699f948d42c 100644 --- a/sys/arm64/vmm/io/vgic_v3.c +++ b/sys/arm64/vmm/io/vgic_v3.c @@ -670,7 +670,7 @@ read_enabler(struct hypctx *hypctx, int n) if (irq == NULL) continue; - if (!irq->enabled) + if (irq->enabled) ret |= 1u << i; vgic_v3_release_irq(irq); }home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6976bad5.8826.652d931e>