Date: Sun, 9 Feb 2014 15:21:09 +0100 From: Emanuel Haupt <ehaupt@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r343457 - head/audio/p5-Shout Message-ID: <20140209152109.4290f49678bfd3db76c19340@FreeBSD.org> In-Reply-To: <EC011389057E119CB2996C3C@atuin.in.mat.cc> References: <201402091101.s19B1aPh072112@svn.freebsd.org> <1E1640591FF296C66F82EF62@atuin.in.mat.cc> <20140209131626.ad5097b391ebb1e6d738e28a@FreeBSD.org> <D51FCA4F34828A264C471DCA@atuin.in.mat.cc> <20140209143756.c1bc46e172d5d5c8979787fc@FreeBSD.org> <EC011389057E119CB2996C3C@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
Mathieu Arnold <mat@FreeBSD.org> wrote: > +--On 9 f=E9vrier 2014 14:37:56 +0100 Emanuel Haupt <ehaupt@FreeBSD.org> > wrote: > |> Yes, and like the wiki[1] says, unless there's a tremendous number > |> of files and the IO hit is pretty severe you should install them > |> always. > |=20 > | So you agree with me that the inclusion is required? >=20 > Nope, the opposite. The wiki says: "The DOCS/EXAMPLES .if blocks can > be made unconditional, except in cases when installed files are big > enough to cause significant I/O overhead."=20 >=20 > In that case, you should have removed the conditional install of the > files, so that they always get staged, and save make of having to > parse bsd.port.mk twice :-) I think you're confused, please look at the Makefile. This is _exactly_ what I made :-) > |> (Also, if those are examples, they should go in EXAMPLESDIR) > |=20 > | I was simply looking at the aspect of converting the port to support > | staging. I don't know if the application requires the files to be > | installed in EXAMPLESDIR or DOCSDIR. >=20 > If they're manually installed by the port, that is, not needed, and > they're called example* you can safely assume that they're examples, > and thus, need to go into the examples directory :-) I wouldn't be so sure. Manual installations in post-install sections are often a result of broken Makefiles. You might be right here but maybe not. All I'm saying is that I do not know for sure as I don't know the application (port) good enough to make this decision. Emanuel
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140209152109.4290f49678bfd3db76c19340>