Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 2 Feb 2011 16:26:30 +1100 (EST)
From:      Bruce Evans <brde@optusnet.com.au>
To:        Garrett Cooper <gcooper@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Alexander Kabaev <kabaev@gmail.com>
Subject:   Re: svn commit: r218177 - head/sys/cddl/compat/opensolaris/sys
Message-ID:  <20110202162235.P1386@besplex.bde.org>
In-Reply-To: <AANLkTinkygz7SKP0hhGJ_apk_4A6-=kQ_PSCi-riLj_d@mail.gmail.com>
References:  <201102012115.p11LFZQh085454@svn.freebsd.org> <AANLkTi=aKso3Z6wxzmoWNRfhARyR0zwJeftLw0jnfUNv@mail.gmail.com> <20110201163844.0c585be4@kan.dnsalias.net> <AANLkTinkygz7SKP0hhGJ_apk_4A6-=kQ_PSCi-riLj_d@mail.gmail.com>

index | next in thread | previous in thread | raw e-mail

On Tue, 1 Feb 2011, Garrett Cooper wrote:

> 2011/2/1 Alexander Kabaev <kabaev@gmail.com>:
>> On Tue, 1 Feb 2011 13:28:43 -0800
>> Garrett Cooper <gcooper@FreeBSD.org> wrote:
>>
>>> On Tue, Feb 1, 2011 at 1:15 PM, Alexander Kabaev <kan@freebsd.org>
>>> wrote:
>>>> Author: kan
>>>> Date: Tue Feb  1 21:15:35 2011
>>>> New Revision: 218177
>>>> URL: http://svn.freebsd.org/changeset/base/218177
>>>>
>>>> Log:
>>>>  Revert r218169 until it can be tested and fixed properly.
>>
>> The real fix from Martin will follow shortly.
>
>    This really needs to be resolved by rearchitecting clock_t to be
> 64-bit on amd64/i386, etc, or add the appropriate shims to handle
> overflow in our opensolaris compatibility layer.

Not really.  As I explained at length, the bug is mostly abusing clock_t
for something that it is not required to do and in fact doesn't do.  You
shouldn't change the ABI of clock_t just to make abuses work.

Bruce
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110202162235.P1386>