Date: Tue, 29 Dec 2015 13:04:31 +0100 From: Mateusz Guzik <mjguzik@gmail.com> To: NGie Cooper <yaneurabeya@gmail.com> Cc: John Baldwin <jhb@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Garrett Cooper <ngie@freebsd.org> Subject: Re: svn commit: r292626 - head/sys/kern Message-ID: <20151229120431.GB15969@dft-labs.eu> In-Reply-To: <2BB34BE5-B312-42DA-B89E-F25B823B9831@gmail.com> References: <201512222107.tBML7XUO053901@repo.freebsd.org> <3052030.KADVjZoIBd@ralph.baldwin.cx> <2BB34BE5-B312-42DA-B89E-F25B823B9831@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 22, 2015 at 02:29:36PM -0800, NGie Cooper wrote: > > > On Dec 22, 2015, at 13:17, John Baldwin <jhb@freebsd.org> wrote: > > > > On Tuesday, December 22, 2015 09:07:33 PM Garrett Cooper wrote: > > … > > > It shouldn't be zero, I think == 1 would be best actually. > > I’ll boot up GENERIC and see whether or not it works with == 1. > Thanks :)! Any value other than in 1 is a bug. The value of 0 means the destination is not used, although it clearly is. Since the counter is signed, sufficiently big amount of users can actually make it negative, although that's an unrealistic for now. TL;DR please change it to equality check against 1. -- Mateusz Guzik <mjguzik gmail.com>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151229120431.GB15969>