Date: Tue, 05 Mar 2013 16:27:07 +0100 From: =?UTF-8?B?SmVhbi1Tw6liYXN0aWVuIFDDqWRyb24=?= <jean-sebastien.pedron@dumbbell.fr> To: freebsd-current@freebsd.org Subject: Re: r247835: drm2 code breaks buildkernel Message-ID: <51360ECB.4000407@dumbbell.fr> In-Reply-To: <20130305095417.3780d487@shibato> References: <5135C70B.50906@zedat.fu-berlin.de> <5135CD0E.8040801@dumbbell.fr> <5135DE36.9010303@zedat.fu-berlin.de> <20130305123016.GE1483@glenbarber.us> <5135FD78.1050608@FreeBSD.org> <20130305095417.3780d487@shibato>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 05.03.2013 15:54, J.R. Oldroyd wrote: > A fix for these is in my big "get it to compile" patch that I emailed > you both the other day. Sorry, I didn't take the time to read it yet :-/ >>> dev/drm2/ttm/ttm_page_alloc.c:122: warning: declaration does not declare anything >>> dev/drm2/ttm/ttm_page_alloc.c:123: warning: declaration does not declare anything > > Experimentation shows that this warning is triggered because we use > -std=iso9899:1999. It can be turned off again by adding --ms-extensions > too. > > Alternatively, my big patch replaces all these anon unions with > named ones. There are lots of these in this code, though. Doing > this adds lots of patch bloat. Yes, the flag is preferable. I didn't have the time to test it earlier either, until now. I confirm that it works with both clang and gcc. > There is a further problem not mentioned here. Three of the files > make use of a pointer to a volatile int but later cast this to a > (void *). Because we also have -Wcast-qual, this cast triggers > "cast discards qualifier on pointer target type" warnings and because > of -Werror, this then aborts. What's the best way to fix that? Those warnings are in the radeon driver, not ttm, aren't they? At least, the build finishes properly on my computer with gcc and clang with just -fms-extensions. -- Jean-Sébastien Pédron [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlE2DtAACgkQa+xGJsFYOlPvpgCglJEZ5Zb45iB5sBJUWR98QriB 1ykAn1Qj/ZYXjUT5hBGfLIJgzQZMhH+G =jWus -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51360ECB.4000407>