Date: Tue, 15 Jan 2019 12:06:17 -0800 From: Gleb Smirnoff <glebius@freebsd.org> To: Justin Hibbits <chmeeedalf@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343058 - in head/sys: compat/linuxkpi/common/src vm Message-ID: <20190115200617.GZ18452@FreeBSD.org> In-Reply-To: <20190115134623.139064b2@titan.knownspace> References: <201901151933.x0FJXl8a069317@repo.freebsd.org> <20190115134623.139064b2@titan.knownspace>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 15, 2019 at 01:46:23PM -0600, Justin Hibbits wrote: J> Why not #include counter.h in the relevant vm_machdep.c files instead? This also is ugly :( Not sure more or less. Probably less, but I urged to plug all possible compilation failures at a time. What is ugly is that most files just need counter_u64_t size, and they don't use counter(9) KPI. The fact that vm_machdep or Linux KPI want to look into internal type uma_zone_t is also ugly. -- Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190115200617.GZ18452>