Skip site navigation (1)Skip section navigation (2) 
Date:      Mon, 02 Mar 2026 18:10:52 +0000
From:      Michael Tuexen <tuexen@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Cc:        Timo =?utf-8?Q?V=C3=B6lker?= <timo.voelker@fh-muenster.de>
Subject:   git: 0272359ada14 - main - arm64/pmap: fix pmap_is_valid_memattr()
Message-ID:  <69a5d2ac.432e0.50b47cad@gitrepo.freebsd.org>
index | next in thread | raw e-mail 

The branch main has been updated by tuexen:

URL: https://cgit.FreeBSD.org/src/commit/?id=0272359ada144aa540c28fefaf996afa30dc0aa5

commit 0272359ada144aa540c28fefaf996afa30dc0aa5
Author:     Timo Völker <timo.voelker@fh-muenster.de>
AuthorDate: 2026-03-02 17:59:45 +0000
Commit:     Michael Tuexen <tuexen@FreeBSD.org>
CommitDate: 2026-03-02 17:59:45 +0000

    arm64/pmap: fix pmap_is_valid_memattr()
    
    The function pmap_is_valid_memattr(pmap, mode) checks whether the
    given variable mode is between the two constant values
    VM_MEMATTR_DEVICE and VM_MEMATTR_WRITE_THROUGH.
    After the code for this function was written, the value of
    VM_MEMATTR_DEVICE changed from 0 to 4. Since VM_MEMATTR_WRITE_THROUGH
    is still 3, the condition is always false.
    This patch changes the condition to check whether mode is equal to any
    of the VM_MEMATTR* constants.
    
    Reviewed by:            andrew, tuexen
    MFC after:              1 week
    Differential Revision:  https://reviews.freebsd.org/D55534
---
 sys/arm64/arm64/pmap.c | 2 +-
 sys/arm64/include/vm.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/sys/arm64/arm64/pmap.c b/sys/arm64/arm64/pmap.c
index 0cfc8ae80d70..25192bfef653 100644
--- a/sys/arm64/arm64/pmap.c
+++ b/sys/arm64/arm64/pmap.c
@@ -9643,7 +9643,7 @@ bool
 pmap_is_valid_memattr(pmap_t pmap __unused, vm_memattr_t mode)
 {
 
-	return (mode >= VM_MEMATTR_DEVICE && mode <= VM_MEMATTR_WRITE_THROUGH);
+	return (mode >= 0 && mode < VM_MEMATTR_END);
 }
 
 static void *
diff --git a/sys/arm64/include/vm.h b/sys/arm64/include/vm.h
index 342143c57246..e03e615bb841 100644
--- a/sys/arm64/include/vm.h
+++ b/sys/arm64/include/vm.h
@@ -33,6 +33,7 @@
 #define	VM_MEMATTR_WRITE_BACK		2
 #define	VM_MEMATTR_WRITE_THROUGH	3
 #define	VM_MEMATTR_DEVICE_nGnRE		4
+#define	VM_MEMATTR_END			(VM_MEMATTR_DEVICE_nGnRE + 1)
 
 #define	VM_MEMATTR_DEVICE		VM_MEMATTR_DEVICE_nGnRE
 #define	VM_MEMATTR_DEVICE_NP		VM_MEMATTR_DEVICE_nGnRnE
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?69a5d2ac.432e0.50b47cad>