Date: Sat, 1 Oct 2016 19:29:00 +0900 (JST) From: Mori Hiroki <yamori813@yahoo.co.jp> To: Adrian Chadd <adrian@freebsd.org>, Patrick Kelsey <pkelsey@freebsd.org> Cc: "freebsd-arm@freebsd.org" <freebsd-arm@freebsd.org>, Ruslan Bukin <br@freebsd.org>, "freebsd-mips@freebsd.org" <freebsd-mips@freebsd.org> Subject: Re: svn commit: r298274 - head/sys/dev/spibus Message-ID: <309539.93259.qm@web101708.mail.ssk.yahoo.co.jp> In-Reply-To: <CAJ-Vmo=ZMygr--HRQen8QQs%2BbME0_u3KKwgwk3zzm6QNHwYZ6g@mail.gmail.com> References: <201604191539.u3JFdkHx048678@repo.freebsd.org> <CAJ-VmonyZR-CiPxceAvVzxDjL7WXDAix-Pmj2RRqp%2B9gj3u0hA@mail.gmail.com> <20160419171243.GA30453@bsdpad.com> <CACVs6=_pN9VAz1kkQQAL-ftKof%2Bkkn5MgxDP1kWj9kM-x=AzbQ@mail.gmail.com> <1461097280.1232.34.camel@freebsd.org> <CAD44qMV1bRA9USafKLSdKv8CcES34G8Kbt54OspaAA_Xdb07xg@mail.gmail.com> <CAJ-Vmo=GiP_NXfBz5ZsJkBm8Ypm-t0udZRqX9BkTa0KuC1bvrw@mail.gmail.com> <CAD44qMWJeTNuXS%2BB1ecJUFN63dweYZRKKG4Ek7kxMk-Mme7=%2BQ@mail.gmail.com> <CAD44qMWbOUaveDtq%2BHn_cYAiU_VGwFEgYJ1vSFYv=4G9XSzzbQ@mail.gmail.com> <CAJ-Vmokwd2wYDMrHQYGBbfvDZ6=32EatZp3k-j1cwUYDMFf%2BTg@mail.gmail.com> <CAD44qMWAEGYJWANW6-4Pf-cCcgsRP_JYbSNhz6Xtv8AM%2BHwD0w@mail.gmail.com> <CAJ-Vmo=ZMygr--HRQen8QQs%2BbME0_u3KKwgwk3zzm6QNHwYZ6g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi.=0A=0AI add SD card socket to my=A0WZR-HP-G300NH(AR9132).=0A=0Ahttps://f= lic.kr/p/MAuUBf=0A=0A=0AI am looking forward to support mmcspi.=0A=0ARegard= s=0A=0AHiroki Mori=0A=0A=0A----- Original Message -----=0A> From: Adrian Ch= add <adrian@freebsd.org>=0A> To: Patrick Kelsey <pkelsey@freebsd.org>=0A> C= c: "freebsd-arm@freebsd.org" <freebsd-arm@freebsd.org>; Ruslan Bukin <br@fr= eebsd.org>; "freebsd-mips@freebsd.org" <freebsd-mips@freebsd.org>=0A> Date:= 2016/5/26, Thu 14:00=0A> Subject: Re: svn commit: r298274 - head/sys/dev/s= pibus=0A> =0A> On 25 May 2016 at 18:57, Patrick Kelsey <pkelsey@freebsd.org= > wrote:=0A>> =0A>> On Fri, May 20, 2016 at 2:35 AM, Adrian Chadd <adrian@= freebsd.org> =0A> wrote:=0A>>> =0A>>> I've reviewed the patches from luiz,= and these look fine. but =0A> indeed,=0A>>> this patchset does set/releas= e the bus each transaction so we can do=0A>>> multiple transactions whilst= holding the bus.=0A>>> =0A>>> Which is fine, but it means I have to undo = ruslan's removal in the =0A> below=0A>>> commit.=0A>>> =0A>>> I'm happy t= o run through and do each of the spi bus drivers (as =0A> there=0A>>> are = more now than the two you patched) but it's a bit close to the=0A>>> 11.0-= release cycle to go and churn the spibus code.=0A>>> =0A>>> But, if people= think it's worth doing it so we can try to get =0A> mmcspi=0A>>> into the= tree before 11.0-rel is cut, I'm happy to run through and =0A> do=0A>>> i= t. I actually have some AR9331 stuff now that could use mmcspi. :)=0A>>> = =0A>>> What do people think?=0A>>> =0A>> =0A>> Thanks, Adrian.=A0 My opin= ion is that the changes to the spi bus interface =0A> and=0A>> the corresp= onding changes to the spi bus drivers you are talking about are=0A>> very = straightforward and low risk.=A0 There is non-zero other interest out=0A>> = there in using the mmcspi driver, based on the couple of emails I've=0A>> = received seeking help on the subject in the last six months or so, so I=0A= >> don't think this would be just a commit for the sake of getting some=0A= >> interesting new code in.=0A> =0A> loos and i are thinking about it. I m= ay start landing some of the=0A> spibus changes tonight just to lay the fou= ndation.=0A> =0A> =0A> =0A> -adrian=0A> ___________________________________= ____________=0A> freebsd-mips@freebsd.org mailing list=0A> https://lists.fr= eebsd.org/mailman/listinfo/freebsd-mips=0A> To unsubscribe, send any mail t= o =0A> "freebsd-mips-unsubscribe@freebsd.org"=0A>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?309539.93259.qm>