Date: Wed, 12 Dec 2018 11:15:13 +0000 (UTC) From: Hans Petter Selasky <hselasky@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: svn commit: r341881 - stable/12/sys/ofed/drivers/infiniband/core Message-ID: <201812121115.wBCBFDKA041132@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: hselasky Date: Wed Dec 12 11:15:12 2018 New Revision: 341881 URL: https://svnweb.freebsd.org/changeset/base/341881 Log: MFC r341534: ibcore: Fix clearing of bound device interface. Binding to a loopback device is not allowed. Make sure the destination device address is global by clearing the bound device interface. Only do this conditionally, else link local addresses won't work. Sponsored by: Mellanox Technologies Modified: stable/12/sys/ofed/drivers/infiniband/core/ib_addr.c Directory Properties: stable/12/ (props changed) Modified: stable/12/sys/ofed/drivers/infiniband/core/ib_addr.c ============================================================================== --- stable/12/sys/ofed/drivers/infiniband/core/ib_addr.c Wed Dec 12 11:14:52 2018 (r341880) +++ stable/12/sys/ofed/drivers/infiniband/core/ib_addr.c Wed Dec 12 11:15:12 2018 (r341881) @@ -649,8 +649,13 @@ static int addr_resolve_neigh(struct ifnet *dev, if (dev->if_flags & IFF_LOOPBACK) { int ret; - /* find real device, not loopback one */ - addr->bound_dev_if = 0; + /* + * Binding to a loopback device is not allowed. Make + * sure the destination device address is global by + * clearing the bound device interface: + */ + if (addr->bound_dev_if == dev->if_index) + addr->bound_dev_if = 0; ret = rdma_translate_ip(dst_in, addr); if (ret == 0) {
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201812121115.wBCBFDKA041132>