Date: Mon, 21 Nov 2011 22:02:12 +0000 From: Alexander Best <arundel@freebsd.org> To: Adrian Chadd <adrian@freebsd.org> Cc: freebsd-wireless@freebsd.org Subject: Re: issues with the recent ath commits (r227740, r227651, ...) Message-ID: <20111121220212.GA9879@freebsd.org> In-Reply-To: <CAJ-VmomO-7-TsT1b_=2FBu5rnYf7Z5UhQyuRF95iupiL2xGTnA@mail.gmail.com> References: <20111121131730.GA3599@freebsd.org> <alpine.BSF.2.00.1111210719430.30516@wonkity.com> <20111121152054.GA22220@freebsd.org> <CAJ-VmomzY6Arh_=nPihdH=RhNyQXV7jgdvV7oyGKfqzb1BQ6sw@mail.gmail.com> <alpine.BSF.2.00.1111211433100.33629@wonkity.com> <CAJ-VmomO-7-TsT1b_=2FBu5rnYf7Z5UhQyuRF95iupiL2xGTnA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue Nov 22 11, Adrian Chadd wrote:
> Hi,
>
> Please try this patch:
thanks for the patch. i'll try it out right away.
>
>
> commit 3993972ed7407867dce188903f68a0751c487fbb
> Author: Adrian Chadd <adrian@freebsd.org>
> Date: Tue Nov 22 05:28:16 2011 +0800
>
> Sleep on the correct lock.
>
> diff --git a/sys/dev/ath/if_ath.c b/sys/dev/ath/if_ath.c
> index 83c5ede..84cb91b 100644
> --- a/sys/dev/ath/if_ath.c
> +++ b/sys/dev/ath/if_ath.c
> @@ -1878,9 +1878,9 @@ ath_txrx_stop(struct ath_softc *sc)
> */
> while (sc->sc_rxproc_cnt || sc->sc_txproc_cnt ||
> sc->sc_txstart_cnt || sc->sc_intr_cnt) {
> - if (i <= 0)
> + if (i <= 0)
what does this change do? ;)
> break;
> - msleep(sc, &sc->sc_mtx, 0, "ath_txrx_stop", 1);
> + msleep(sc, &sc->sc_pcu_mtx, 0, "ath_txrx_stop", 1);
> i--;
> }
> ATH_PCU_UNLOCK(sc);
cheers.
alex
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111121220212.GA9879>