Date: Wed, 03 Sep 2008 15:12:45 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: "army.of.root\@googlemail.com" <army.of.root@googlemail.com> Cc: freebsd-current@FreeBSD.org, Rui Paulo <rpaulo@FreeBSD.org> Subject: Re: k8temp choose the higher temp of the two sensors on one core Message-ID: <86d4jl9xv6.fsf@ds4.des.no> In-Reply-To: <48BB403C.5090103@googlemail.com> (army's message of "Mon, 01 Sep 2008 03:07:08 %2B0200") References: <48BB403C.5090103@googlemail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
"army.of.root@googlemail.com" <army.of.root@googlemail.com> writes:
> I noticed that not the highest of the two temp values of one core is used:
>
> dev.cpu.0.temperature: 46
> dev.cpu.1.temperature: 46 <==
> dev.k8temp.0.%desc: AMD K8 Thermal Sensors
> dev.k8temp.0.%driver: k8temp
> dev.k8temp.0.%parent: hostb3
> dev.k8temp.0.sensor0.core0: 46
> dev.k8temp.0.sensor0.core1: 49 <==
> dev.k8temp.0.sensor1.core0: 46
> dev.k8temp.0.sensor1.core1: 46
>
> I assume the dev.cpu.1.temperature sysctl comes from the k8temp
> module, because it only shows up if it is loaded.
That's not the only error:
sysctlnode = SYSCTL_ADD_NODE(sysctlctx,
SYSCTL_CHILDREN(device_get_sysctl_tree(dev)), OID_AUTO, "sensor1",
CTLFLAG_RD, 0, "Sensor 1");
SYSCTL_ADD_PROC(sysctlctx,
SYSCTL_CHILDREN(sysctlnode),
OID_AUTO, "core0", CTLTYPE_INT | CTLFLAG_RD,
dev, SENSOR0_CORE0, k8temp_sysctl, "I",
"Sensor 1 / Core 0 temperature");
SYSCTL_ADD_PROC(sysctlctx,
SYSCTL_CHILDREN(sysctlnode),
OID_AUTO, "core1", CTLTYPE_INT | CTLFLAG_RD,
dev, SENSOR0_CORE0, k8temp_sysctl, "I",
"Sensor 1 / Core 1 temperature");
Another thing - wouldn't coreX.sensorY make more sense than
sensorY.coreX?
DES
--
Dag-Erling Smørgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86d4jl9xv6.fsf>