Date: Tue, 26 Dec 2017 17:54:18 +0100 From: Michael Tuexen <tuexen@freebsd.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r327205 - head/sys/netinet/libalias Message-ID: <6ED1D4C5-0A61-463D-AAB2-662E36D2E4FB@freebsd.org> In-Reply-To: <20171226160000.GB90333@FreeBSD.org> References: <201712261524.vBQFOggM046909@repo.freebsd.org> <20171226160000.GB90333@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 26. Dec 2017, at 17:00, Alexey Dokuchaev <danfe@FreeBSD.org> wrote: > > On Tue, Dec 26, 2017 at 03:24:42PM +0000, Michael Tuexen wrote: >> New Revision: 327205 >> URL: https://svnweb.freebsd.org/changeset/base/327205 >> >> Log: >> Fix CID 1008936. > > I'm afraid this is a rather bad commit message. It should have described > what was the problem and how it was approached (fixed). Listing CID is > part of the metadata; it cannot replace proper commit log. It replaced a comparison left side == right side with identical left and right sides with the correct condition. I guess that was a copy and paste error. > > Also, please do not mix functional and substantial amount of style changes > in a single commit. Yepp. You are right. Will do in the future... Best regards Michael > > ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6ED1D4C5-0A61-463D-AAB2-662E36D2E4FB>