Date: Wed, 03 Apr 2002 23:05:32 -0800 From: Terry Lambert <tlambert2@mindspring.com> To: Peter Wemm <peter@wemm.org> Cc: David Greenman <dg@root.com>, Will Froning <wfroning@angui.sh>, hackers@FreeBSD.ORG Subject: Re: Fatal trap 12: page fault while in kernel mode Message-ID: <3CABFB3C.E2E40D7B@mindspring.com> References: <20020404055149.CE6263811@overcee.wemm.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Peter Wemm wrote:
> > You will need to modify nfs_realign() to take a waitflag,
+++++++++++++++++++++++++++++++++++++++
> > as propagated from nfsrv_rcv()... and then pass it through
*************************
> Terry, if you spent half of the time reading the code as speculating and
> writing about your wild speculation, you'd know that we already have a
> "waitflag" for nfsrv_rcv() to track safeness to wait or not.
If you had read the above, you'd see I knew that. Note the
asterisk marked phrase.
> The bug is that
> nfs_realign doesn't take the 'waitflag' argument and has two 'can wait'
> mbuf allocation calls.
I said that, too. Note the plus sign marked phrase. 8-).
> The fix is trivial and hardly ugly. But then again, anybody who actually
> bothered to read the code before posting would know that.
It was a general comment on the NFS code.
You suggested exactly the same fix I did...
-- Terry
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3CABFB3C.E2E40D7B>