Date: Tue, 31 Mar 2009 11:03:14 +0300 From: Max Brazhnikov <makc@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Emanuel Haupt <ehaupt@critical.ch>, Martin Matuska <mm@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, Ion-Mihai Tetcu <itetcu@FreeBSD.org> Subject: Re: cvs commit: ports/audio/lame Makefile Message-ID: <200903311203.15205.makc@FreeBSD.org> In-Reply-To: <20090331062655.GA80013@FreeBSD.org> References: <200903242000.n2OK0XIp085445@repoman.freebsd.org> <200903301940.44496.makc@freebsd.org> <20090331062655.GA80013@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 31 Mar 2009 06:26:55 +0000, Alexey Dokuchaev wrote:
> On Mon, Mar 30, 2009 at 07:40:44PM +0400, Max Brazhnikov wrote:
> > On Mon, 30 Mar 2009 18:10:42 +0300, Ion-Mihai Tetcu wrote:
> > > On Mon, 30 Mar 2009 14:26:22 +0000
> > >
> > > Alexey Dokuchaev <danfe@FreeBSD.org> wrote:
> > > > On Mon, Mar 30, 2009 at 04:00:43PM +0200, Emanuel Haupt wrote:
> > > > > > lame fails on my tinderbox after enabling jobs. Removing
> > > > > > MAKE_JOBS_SAFE helps.
> > > > >
> > > > > In that case it should be marked MAKE_JOBS_UNSAFE.
> > > >
> > > > Weird. I could not reproduce it on i386 with make -DFORCE_MAKE_JOBS
> > > > MAKE_JOBS_NUMBER=8. Is there build log available? I'd rather fix
> > > > the port than blindly mark it as MAKE_JOBS_UNSAFE.
> > >
> > > It also builds OK with MAKE_JOBS_NUMBER=16, on amd64-{6,7,8}
> >
> > Build log:
> > http://people.freebsd.org/~makc/tmp/lame-3.98.2_1.log
> >
> > ~> sysctl -n kern.smp.cpus
> > 4
>
> I could not reprocude it, maybe my box is too slow or something.
> However, many Linux distros include this patch named ``lame-pmake.patch'',
> and say something about fixing parallel builds. It looks like it might
> fix what you see (some race between test -d and mkdir).
>
> Can you check please? Patch (this one is from ASP Linux) is attached.
Yes, this patch solves the problem.
Max
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200903311203.15205.makc>