Date: Fri, 27 Apr 2012 20:03:15 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: Warren Block <wblock@wonkity.com>, matt <sendtomatt@gmail.com> Cc: x11@FreeBSD.org, freebsd-ports@FreeBSD.org Subject: Re: New X.Org Message-ID: <4F9AD153.4000103@FreeBSD.org> In-Reply-To: <alpine.BSF.2.00.1204260912001.20978@wonkity.com> References: <4F9541DD.3080200@netfence.it> <alpine.BSF.2.00.1204230648560.68901@wonkity.com> <4F956713.60604@gmail.com> <alpine.BSF.2.00.1204231032020.69711@wonkity.com> <4F979BCA.9050800@gmail.com> <4F98F3BC.3020305@gmail.com> <alpine.BSF.2.00.1204260912001.20978@wonkity.com>
next in thread | previous in thread | raw e-mail | index | archive | help
on 26/04/2012 18:45 Warren Block said the following:
> On Thu, 26 Apr 2012, matt wrote:
>
>>>>> Interesting. Another Radeon 4650 (rv730) is not working here, giving Bus
>>>>> Errors at the same address whenever certain applications are launched.
>>>>> Failing examples: Firefox, gedit, qt4-designer Successful: xfce4-terminal,
>>>>> ioquake3, compiz
>>>
>> Fixed this issue using the changes indicated in the below patch, which
>> solved my issue with x bus errors. It looks like glxGetScreen was
>> choking. This may help users with similar problems in compiz or Kwin.
>> FYI I manually applied changes in the patch to x11-servers/xorg-server,
>> not sure if the patch below would apply cleanly.
>>
>> diff --git a/glx/glxdri.c b/glx/glxdri.c
>> index 326f539..f6ef784 100644
>> --- a/glx/glxdri.c
>> +++ b/glx/glxdri.c
>> @@ -230,7 +230,7 @@ __glXDRIdrawableDestroy(__GLXdrawable *drawable)
>>
>> /* If the X window was destroyed, the dri DestroyWindow hook will
>> * aready have taken care of this, so only call if pDraw isn't NULL. */
>> - if (drawable->pDraw != NULL) {
>> + if (drawable->pDraw != NULL && drawable->pDraw->type == DRAWABLE_WINDOW) {
>> screen = (__GLXDRIscreen *) glxGetScreen(drawable->pDraw->pScreen);
>> (*screen->core->destroyDrawable)(private->driDrawable);
>>
>
> Good catch! Please enter a PR for this!
Just double-check that this change doesn't introduce any memory/resource leaks :-)
--
Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F9AD153.4000103>