Date: Tue, 07 Jun 2022 15:13:58 +0000 From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 252316] [PATCH] add OCF offloading to ZFS Message-ID: <bug-252316-3630-CB5mexFGiw@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-252316-3630@https.bugs.freebsd.org/bugzilla/> References: <bug-252316-3630@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D252316 --- Comment #5 from John Baldwin <jhb@FreeBSD.org> --- I don't think the patch is correct. I think the issue is probably that you aren't using a separate output buffer, and in the case that we aren't using= a separate buffer, we should just assert that the output_payload_start is 0 a= nd not check it otherwise. Or perhaps you are using the output only for the digest and not doing encryption? In that case your patch might indeed be correct. I think though in that case we'd like to assert that payload_output_start is not used (i.e. 0), something like: if (csp->mode =3D=3D CSP_MODE_DIGEST) KASSERT(payload_output_start =3D=3D 0) else /* existing test that output region fits in olen */ --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-252316-3630-CB5mexFGiw>